Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image name used as menu icon configurable #48

Open
sunweaver opened this issue Jun 27, 2022 · 1 comment
Open

Make image name used as menu icon configurable #48

sunweaver opened this issue Jun 27, 2022 · 1 comment

Comments

@sunweaver
Copy link
Contributor

sunweaver commented Jun 27, 2022

Hi,

I am currently working on a project where I want to use the Yaru theme on a non-Ubuntu distribution in combination with Brisk Menu. The Yaru theme ships the Ubuntu circle-of-friends as start-here-symbolic.svg. This (circle of friends as start menu icon) works nice on Ubuntu systems, but feels misplaced on Debian, openSUSE, etc.

I have been thinking about how to amend this for my system, initially thought that I have to provide some patch to the Yaru theme, but I now found a much easier and more generic approach (that Brisk Menu will benefit from).

I'd like to ask my co-developer on this customer project to provide a patch for Brisk Menu that allows one to customize the icon name used as start menu icon.

I can then provide a MATE start menu icon via another package that resembles the Yaru icon style (and drop it into /usr/share/icons/Yaru/...), tweak Brisk Menu's new icon-name gsettings option via an override and tadaaa... have my own customized icon in Brisk Menu.

Please veto now if you feel this is a bad idea.

Please note, that MATE's classical menubar applet also provides an 'icon-name' gsettings parameter, the idea is to immitate its behaviour and port it over to Brisk Menu.

@sunweaver sunweaver changed the title Make image name used menu icon configurable Make image name used as menu icon configurable Jun 27, 2022
@sunweaver
Copy link
Contributor Author

@flexiondotorg highlighting Wimpy on this ^^^

Ionic added a commit to Ionic/brisk-menu that referenced this issue Jun 28, 2022
The actual icon can now be changed via the icon-name gsettings key.

By default, the applet will load a symbolic version of the icon. This
behavior can be changed via the icon-symbolic key.

Changes to any of these keys should directly be visible.

Fixes: getsolus#48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant