Skip to content

Commit c8d8de6

Browse files
fixup! [naga spv-out msl-out hlsl-out] Make infinite loop workaround count down instead of up
1 parent a1bc22f commit c8d8de6

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

naga/src/back/hlsl/writer.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ impl<'a, W: fmt::Write> super::Writer<'a, W> {
172172
let loop_bound_name = self.namer.call("loop_bound");
173173
let max = u32::MAX;
174174
// Count down from u32::MAX rather than up from 0 to avoid hang on
175-
// certain Intel drivers. See https://github.com/gfx-rs/wgpu/issues/7319.
175+
// certain Intel drivers. See <https://github.com/gfx-rs/wgpu/issues/7319>.
176176
let decl = format!("{level}uint2 {loop_bound_name} = uint2({max}u, {max}u);");
177177
let level = level.next();
178178
let break_and_inc = format!(

naga/src/back/msl/writer.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -851,7 +851,7 @@ impl<W: Write> Writer<W> {
851851

852852
let loop_bound_name = self.namer.call("loop_bound");
853853
// Count down from u32::MAX rather than up from 0 to avoid hang on
854-
// certain Intel drivers. See https://github.com/gfx-rs/wgpu/issues/7319.
854+
// certain Intel drivers. See <https://github.com/gfx-rs/wgpu/issues/7319>.
855855
let decl = format!("{level}uint2 {loop_bound_name} = uint2({}u);", u32::MAX);
856856
let level = level.next();
857857
let break_and_inc = format!(

naga/src/back/spv/block.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ impl BlockContext<'_> {
364364
// the high u32 when the low u32 overflows. ie
365365
// counter -= vec2(select(0u, 1u, counter.y == 0), 1u);
366366
// Count down from u32::MAX rather than up from 0 to avoid hang on
367-
// certain Intel drivers. See https://github.com/gfx-rs/wgpu/issues/7319.
367+
// certain Intel drivers. See <https://github.com/gfx-rs/wgpu/issues/7319>.
368368
let low_id = self.gen_id();
369369
block.body.push(Instruction::composite_extract(
370370
uint_type_id,

0 commit comments

Comments
 (0)