Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACUS: change hotel pages to use hotel booking info from configuration settings #163

Open
evoskamp opened this issue Jan 21, 2024 · 3 comments · May be fixed by #162
Open

ACUS: change hotel pages to use hotel booking info from configuration settings #163

evoskamp opened this issue Jan 21, 2024 · 3 comments · May be fixed by #162
Assignees
@evoskamp
Labels
ACUS enhancement New feature or request

Comments

@evoskamp
Copy link
Collaborator

Hotel settings added, but not used.
@evoskamp evoskamp added the ACUS label Jan 21, 2024
@evoskamp evoskamp self-assigned this Jan 21, 2024
evoskamp added a commit that referenced this issue Jan 21, 2024
@evoskamp
Move static MDX content to TSX with config settings
98e0787 
Wanted to pick up hotel booking code and link and book by date, as
we change those apparently every year. And also wanted to pick up
the contact email from settings.

Resolves: #163, #155, #158, #160, #161, #159
@evoskamp evoskamp linked a pull request Jan 21, 2024 that will close this issue
Move values into configuration settings, stop checking # of slots, use the same magic event ids #162
Open
@ggascoigne
Copy link
Owner

You're welcome to migrate from mdx over to tsx like this, but you can also access the config settings by using components that do the appropriate lookup and return the values as elements. I switched these big blocks of text from tsx over to mdx to make it easier for non-devs to edit, but perhaps that's less of an issue now, or at least less for acus.

@evoskamp
Copy link
Collaborator Author

Yeah, I was looking at least effort, as I'm the only one maintaining content and it's pretty much static, except for the hotel links.

@evoskamp
Copy link
Collaborator Author

Yeah, since I think the only uses were on this page it didn't feel right to make components for them.

@evoskamp evoskamp added the enhancement New feature or request label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evoskamp evoskamp

Labels
ACUS enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@ggascoigne @evoskamp