Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote ggtracker/sc2reader to be the official version #26

Open
dsjoerg opened this issue Apr 18, 2016 · 3 comments
Open

Promote ggtracker/sc2reader to be the official version #26

dsjoerg opened this issue Apr 18, 2016 · 3 comments

Comments

@dsjoerg
Copy link
Member

dsjoerg commented Apr 18, 2016

From @dsjoerg on July 16, 2014 18:47

Currently we use an old and behind version of sc2reader: https://github.com/ggtracker/sc2reader/tree/upstream

Which is less efficient, and also not as easily compatible with the newer sc2reader.

Copied from original issue: dsjoerg/ggpyjobs#1

@dsjoerg
Copy link
Member Author

dsjoerg commented Apr 18, 2016

From @dmpaul26 on March 11, 2016 2:58

Since the version currently used is a bunch of commits ahead and behind the newer sc2reader, my thought was comparing the two branches and going through each commit from the newer sc2reader and make sure there are no conflicts, then checking for logic/runtime compatibility?

This is also old, I'm sure the incompatibility has gotten even more extreme?

@dsjoerg
Copy link
Member Author

dsjoerg commented Apr 18, 2016

This would be difficult, more difficult than all the other things we've talked about doing.

@dsjoerg
Copy link
Member Author

dsjoerg commented Nov 16, 2016

Since GraylinKim/sc2reader is no longer under active development, the more recent thought is to promote https://github.com/ggtracker/sc2reader/tree/upstream to being the official sc2reader

@dsjoerg dsjoerg changed the title Use a more modern version of sc2reader Promote ggtracker/sc2reader to be the official version Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant