-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name of repository is misleading because it does not contain a language server #112
Comments
Yes, it's a little bit pendantic.
At the beginning, the language server was there.
Then only the integrations remain.
It's an implementation detail!
Feel free to create a pull request for changes in the README, but changing a repo name is not nice for the existing users.
|
@tgingold Renaming the repository shouldn't be a problem, because GitHub maintains redirects (even for Git) in the background. So almost nothing should break for old users. I also would prefer to cleanup the naming, so the repository reflects it's content. |
So as it stands, is it more appropriate to add language server issues to this repository, or to the PyGHDL/GHDL main repository (where the source code is actually located) |
It doesn't really matter. Use your best judgement.
|
No better name has been suggested!
|
As this is a language server protocol client, I propose: Repository name: |
(Sorry, this is a particularly pedantic issue)
The name of this repository is "ghdl-language-server" which strongly suggests that it contains the ghdl language server. However instead, it actually contains language server clients for VS code and emacs.
Additionally, all sections of README.md up to section "Visual Studio Code (VSC) Extension" are not relevant to this repository because they refer to the language server, which is not hosted in this repository.
The text was updated successfully, but these errors were encountered: