Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of repository is misleading because it does not contain a language server #112

Open
Farmadupe opened this issue Apr 13, 2022 · 6 comments

Comments

@Farmadupe
Copy link

(Sorry, this is a particularly pedantic issue)

The name of this repository is "ghdl-language-server" which strongly suggests that it contains the ghdl language server. However instead, it actually contains language server clients for VS code and emacs.

Additionally, all sections of README.md up to section "Visual Studio Code (VSC) Extension" are not relevant to this repository because they refer to the language server, which is not hosted in this repository.

@tgingold
Copy link
Member

tgingold commented Apr 13, 2022 via email

@Paebbels
Copy link
Member

@tgingold Renaming the repository shouldn't be a problem, because GitHub maintains redirects (even for Git) in the background. So almost nothing should break for old users.

I also would prefer to cleanup the naming, so the repository reflects it's content.
But yes, I also understand were the name originates from.

@Aniruddha-Deb
Copy link

So as it stands, is it more appropriate to add language server issues to this repository, or to the PyGHDL/GHDL main repository (where the source code is actually located)

@tgingold
Copy link
Member

tgingold commented Sep 29, 2022 via email

@tgingold
Copy link
Member

tgingold commented Oct 11, 2022 via email

@Paebbels
Copy link
Member

As this is a language server protocol client, I propose:

Repository name: ghdl-lsp-client
Repository description: LSP clients for VS Code and Emacs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants