-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/adding mset replacement functionality 20210615 #445
Open
cschu
wants to merge
65
commits into
develop
Choose a base branch
from
feature/adding_mset_replacement_functionality_20210615
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
b73c2c9
added MsetReplacementEvent model
cschu c61ae1d
fixed alembic complaint
cschu 723ec8b
added alembic script for revision related to b73c2c91
cschu e53527b
pleasing flake8
cschu 157ef00
Merge branch 'develop' into feature/adding_mset_replacement_functiona…
cschu 0708ccb
Merge branch 'develop' into feature/adding_mset_replacement_functiona…
cschu 3dbc0f4
fixed MsetReplacement/MetaDataSet key issues (with @lkuchenb)
cschu df35eba
merged upstream
cschu 1b3a3fc
pleasing flake8
cschu 9f09d96
Merge branch 'develop' into feature/adding_mset_replacement_functiona…
cschu 729ddcc
added initial mset replacement logic
cschu 85ade91
merged upstream
cschu 2bd9b75
pleasing flake8 and mypy
cschu 523208f
addressing @lkuchenb's code review
cschu 9068be3
added user.can_update flag
cschu 2392560
generated alembic script pertaining to 9068be3
cschu 54d3b63
pleasing flake8
cschu 1c9a668
pleasing flake8
cschu 1ffefdb
Merge branch 'develop' into feature/adding_mset_replacement_functiona…
cschu bf20b41
fixing the fixtures
cschu 67fe823
fixing the fixtures
cschu 9accbed
addressing mypy error
cschu 5db3d83
implemented code review requests (@lkuchenb)
cschu b92e67e
patched exposed event id
cschu 307353f
actually fixed exposed event id
cschu f5d2483
added can_update to restricted fields, updated info request integrati…
cschu 7a4c6de
added metadataset->msetreplacementevent relationships
cschu effc7d7
simplified check for already replaced metadatasets
cschu db6efbc
added back_populates args
cschu 6c7199b
fixed issue with introducing can_update column for existing users
cschu 621babc
Merge branch 'develop' into feature/adding_mset_replacement_functiona…
cschu 55a11f7
openapi version bump (1.4.0)
cschu c6a340f
added/registered new api route; renamed information request operation…
cschu e0dfe33
added update_metadatasets protoype
cschu ce78f8a
Merge branch 'develop' into feature/adding_mset_replacement_functiona…
cschu 4fecd28
pleasing flake8 and mypy
cschu 115eff6
package bump (pleasing versioning checks)
cschu 4912fdb
merged openapi.yaml with upstream changes
cschu 36cd8ec
Apply suggestions from code review
cschu ac112b7
works
cschu 4a35bce
weird.
cschu e0803da
weird.
cschu 6f75123
weird
cschu d0b3f6b
refactored + working
cschu e77bf56
added preliminary test for metadataset replacement
cschu 0289f2a
workaround to re-enable bulk-deletion test
cschu ac2b431
removed redundant label from msetreplacementevents (label is attached…
cschu 3e1bfcd
cleaning
cschu c6f22a0
added can_update=True to initial user
cschu 9e88373
metadatasetresponses now include replaced/replaces information (#462)
cschu d882ffe
added more testcases
cschu d395384
pleasing flake8
cschu b7cf1ed
pleasing mypy
cschu e47a56d
pleasing mypy
cschu b87e481
removed comment
cschu 455ee05
added information about replaced metadatasets to datatable
cschu 27163f5
Apply suggestions from @lkuchenb's code review
cschu 306cf35
implemented suggestions from @lkuchenb's code review
cschu d353255
merge upstream (github code review)
cschu 455626a
dealt with fallout from renaming msetreplacements-table
cschu 00738a1
fixed bulk deletion test
cschu ea30854
fixed failing stage_and_submit test
cschu cbe39eb
pleasing mypy
cschu dd036cc
fixed issue that prevented new user registration requests to be compl…
cschu 216a08b
Merge branch 'develop' into feature/adding_mset_replacement_functiona…
lkuchenb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zip()
returns tuples, not listsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that i know :P but why does it not complain in validation.py, line 63, which also uses zip-derived values for the arguments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea. But we should probably not be so strict about the argument type in
errors.get_validation_error
and relax it toIterable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.