Fix Safari DNR rule converter - drop unsupported regexps (#1959)

ghostery · Oct 14, 2024 · a014834 · a014834
1 parent e039572
commit a014834
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/src/utils/dnr-converter-safari.js b/src/utils/dnr-converter-safari.js
@@ -17,6 +17,18 @@ export function convert(r) {
     );
   }
 
+  // Based on https://github.com/w3c/webextensions/issues/344#issuecomment-1430358116
+  if (
+    rule.condition.regexFilter?.match(/(\{\d*,\d*\})/) ||
+    rule.condition.regexFilter?.match(/(\{\d+\})/)
+  ) {
+    throw new Error(`regexp not supported: {n,m} quantifier`);
+  }
+
+  if (rule.condition.regexFilter?.match(/\(([^()]*[|][^()]*)\)/)) {
+    throw new Error(`regexp not supported : | - capture group disjunction`);
+  }
+
   if (
     rule.action.type === 'allowAllRequests' &&
     (!rule.condition.resourceTypes ||