-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(panel): Add the "Report a broken page" view #2164
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far!
src/background/broken-page-report.js
Outdated
'support_ticket[subject]', | ||
`[GBE] Broken page report: ${msg.url}`, | ||
); | ||
formData.append('support_ticket[message]', msg.description); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should pass the product version via the form. Until it is supported by the website lets add it to the message.
Lets consider if we want to add also:
- list of detected activities (no urls)
- extension settings
- block list version (checksums)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to miss it, I'll add the extension version via the subject. It might be easier to spot or filter out.
The message body has a limit of 5k characters. We can shorten it to 4k for a space of 1k for additional metadata. We can add a list of tracker IDs (from stats), extension settings are important from the privacy section only. The block list might be tricky as it requires all checksums of all lists, but I will try to generate them.
} | ||
}); | ||
|
||
sendResponse(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add some error handling so in case of a problem we let people know they can report the problem via the website?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. That's technically easy, I will add a message after error handling, like "Error... However, you can always report the broken page via our [website form]"
6df993b
to
5daf8e8
Compare
The PR adds the CTA for paused domains, which opens the "Report a broken page" in the panel.
activeTab
permission does not trigger a browser popup when the extension is updated. However, we can also try out the optional permission if it is better.mac
,win
,ios
,ipados
,linux
, etc... and version only as a separate field (currently we havewindows_10
and other as os name)WARNING: the PR logic is finished and it's connected to the real end-point. Please use
npm start -- --staging
when testing to avoid spaming the support channel.