Memory Leak

[tiredenzo]

Hello I experienced a memory leak which crashed my async jobs using this gem

This seriously leaks:

10000.times do (puts (Tilt::HandlebarsTemplate.new { "{{enzo}}" }).render({enzo: 'LOL'})) end

This does not Leak:

100000.times do (puts (Tilt::ERBTemplate.new { "<%= enzo %>" }).render(Hashie::Mash.new({enzo: 'LOL'}))) end

I will try to investigate it further today,
Thank you

[tiredenzo]

Actually only

100000.times do Tilt::HandlebarsTemplate.new do '' end end

is enough to perform a leak

[jimothyGator]

Thanks for the test case. I've been swamped with the day job, but will try to take a look at this ASAP. If you've got a chance, you may want to see if you can create a memory leak with straight Handlebars.rb, not using tilt. That'll help isolate where the bug lies.

[tiredenzo]

I'm still trying to isolate the bug on my free time...
if you have any suggestions on how I should proceed (gdb, ruby debug or else) you are welcomed
for now I think the leak is in

def prepare
  @context.partial_missing { |partial_name| load_partial partial_name }
end

[tiredenzo]

This is weird because in my interpreter if I run

require 'handlebars'
10000.times do ::Handlebars::Context.new.partial_missing do |partial_name| '' end end

Handlebars.rb seems to work without leaking

but if i change in tilt-handlebars

def prepare
  @context = ::Handlebars::Context.new
  @context.partial_missing { '' }
end

and execute in my interpreter

require 'tilt/handlebars'
10000.times do Tilt::HandlebarsTemplate.new do '' end end

This still leaks; So i'll give a try between the interaction of tilt and tilt-handlebars as for me Handlebars.rb gem is not leaking

[jimothyGator]

Possibly related: cowboyd/handlebars.rb#38

[donbobka]

👍

[gi]

The Handlebars engine referenced in this issue has been replaced with https://github.com/gi/handlebars-ruby.

i'm going to close this issue because, after testing this with the new engine, there no longer seems to be an issue.