Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 #23

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

v4 #23

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
charset = utf-8
end_of_line = crlf
indent_size = 4
indent_style = space
indent_style = tab
insert_final_newline = false
max_line_length = 120
tab_width = 4
Expand Down Expand Up @@ -846,6 +846,8 @@ ij_html_text_wrap = normal
ij_html_uniform_ident = false

[{*.markdown, *.md}]
indent_size = 4
indent_style = tab
ij_markdown_force_one_space_after_blockquote_symbol = true
ij_markdown_force_one_space_after_header_symbol = true
ij_markdown_force_one_space_after_list_bullet = true
Expand Down
9 changes: 6 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ to [[email protected]](mailto:[email protected]).

## What should I know before I get started?

In order to be able to build the app you will need to rename the secrets_sample.txt file into secrets.xml.
In order to run the code localy you will need to either setup a composer and a virtual host on your own machine or use a docker to assist you with that.

## How Can I Contribute?

Expand Down Expand Up @@ -142,6 +142,10 @@ to complete additional design work, tests, or other changes before your pull req

## Style guides

* It is preffered to use tabs for indentation, but the `.editorconfig` file should help with that.
* For some langauges or definitions it may not be perfect but try to respect settings from it.


### Git Commit Messages

* Use the present tense ("Add feature" not "Added feature")
Expand All @@ -164,9 +168,8 @@ to complete additional design work, tests, or other changes before your pull req
* :lock: `:lock:` when dealing with security
* :arrow_up: `:arrow_up:` when upgrading dependencies
* :arrow_down: `:arrow_down:` when downgrading dependencies
* :shirt: `:shirt:` when removing linter warnings

# Note

This contributing guide has been adapted from the [Atom](https://github.com/atom/atom/blob/master/CONTRIBUTING.md)
repository for this project.
repository for this project. Some thing may not fully reflect the current state of the project and for any questions feel free to reach to via `Discussions` tab or other means listed on the repo owner's profile.
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ When using chained methods either use `->save()` or `->add()` as the last method
**NOTE**

* `->save(true|false)` method can still be chained onto if needed
* Passing `false` (the default value is `true`) to the `->save()` method will preserve all the previous prefixes and middlewares in that chain
* Passing `false` (the default value is `true`) to the `->save()` method will preserve all the previous prefixes and
middlewares in that chain
* `->add()` **CAN NOT** be chained onto and should be the last call in chain

```php
Expand Down Expand Up @@ -302,4 +303,4 @@ Source code documentation can be found at [PHP Routing documentation](https://gi
* [x] Method chaining
* [x] Dependency injection on classes
* [x] Manual injection
* [x] Auto-injection
* [x] Auto-injection
11 changes: 6 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,10 @@
}
],
"require": {
"php" : ">=8.0",
"ext-json" : "*",
"ext-mbstring" : "*"
"php": ">=8.0",
"ext-json": "*",
"ext-mbstring": "*",
"psr/http-server-handler": "^1.0"
},
"autoload": {
"psr-4": {
Expand All @@ -56,9 +57,9 @@
},
"extra" : {
"branch-alias" : {
"dev-master" : "3.x-dev"
"dev-master" : "4.x-dev"
}
},
"prefer-stable" : true,
"minimum-stability" : "dev"
}
}
Loading
Loading