Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to selenium-jupiter v5.0.0 fails #36

Closed
javiertuya opened this issue Nov 3, 2023 · 4 comments
Closed

Update to selenium-jupiter v5.0.0 fails #36

javiertuya opened this issue Nov 3, 2023 · 4 comments
Assignees
Labels
regression Something stopped working

Comments

@javiertuya
Copy link
Contributor

See #35

@javiertuya javiertuya added the regression Something stopped working label Nov 3, 2023
@augustocristian
Copy link
Contributor

Currently, I'm in the process of updating the Java version to 21, the latest stable release. I'm also analyzing the slave version to ensure it aligns with the new versions used on GitHub @javiertuya .

@javiertuya
Copy link
Contributor Author

@augustocristian Java 21 is not necessary, the general rule of thumb is: use the minimum LTS that is compatible

@augustocristian
Copy link
Contributor

According to the Changelog, the project has been updated to use Java 17, ensuring complete alignment and the utilization of the Selenide dependency. In the documentation, it states: 'Selenium-Jupiter should be employed as a Java dependency (requiring JDK 17 or higher). '". "The agent is now on Alpine 17, ensuring alignment. @javiertuya

@javiertuya
Copy link
Contributor Author

@augustocristian As I told before (somewere), NEVER add commits to dependabot updates, because this will prevent to be included in combined updates (as they will cherry pick the latest commit only).

According to the changelog, the requirement is java 17, not java 21:
image

I have deleted the branch and recreated the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Something stopped working
Projects
None yet
Development

No branches or pull requests

2 participants