Fix new sonarcloud smells (#319)

* Update Base.java * Update TestSqlserverSchemaMetadata.java
giis-uniovi · Dec 8, 2024 · 8531288 · 8531288
1 parent fb694b7
commit 8531288
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/tdrules-client-oa/src/test/java/test4giis/tdrules/client/oa/Base.java b/tdrules-client-oa/src/test/java/test4giis/tdrules/client/oa/Base.java
@@ -69,7 +69,7 @@ protected void assertModelMermaid(String fileName, String mermaidModel) throws I
 	protected void assertModelFile(String fileName, String actualFile) throws IOException {
 		// saves actual in target, reads expected file from resources and performs the
 		// assert
-		fileWrite(TEST_PATH_OUTPUT, fileName, actualFile.toString());
+		fileWrite(TEST_PATH_OUTPUT, fileName, actualFile);
 		actualFile = actualFile.replace("\r", "");
 		String expected = fileRead(TEST_PATH_BENCHMARK, fileName).replace("\r", "");
 		new VisualAssert().setFramework(Framework.JUNIT4).setBrightColors(true)

diff --git a/tdrules-store-rdb/src/test/java/test4giis/tdrules/store/rdb/TestSqlserverSchemaMetadata.java b/tdrules-store-rdb/src/test/java/test4giis/tdrules/store/rdb/TestSqlserverSchemaMetadata.java
@@ -48,9 +48,11 @@ protected void createViewXXL() throws SQLException {
 		String createViewSql = "select tinteger,tint4,tcharacter from stypes1";
 		String addView = " \nunion all " + createViewSql;
 		int numRepeats = 10000 / addView.length();
+		StringBuilder sb = new StringBuilder();
+		sb.append(createViewSql);
 		for (int i = 0; i < numRepeats; i++)
-			createViewSql += addView;
-		execute(dbt, createViewMain + createViewSql);
+			sb.append(addView);
+		execute(dbt, createViewMain + sb.toString());
 	}
 
 	protected void createTablesAndViews() throws SQLException {