-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gap parameter? #7
Comments
@thedimiks Hi, did you find a solution to this? I'm trying to handle the gaps too (both vertical and horizontal) |
I figured just adding padding to the inner div is doing the trick. |
@mapsteps, thanks for the answer, not so fancy but if it works... |
@mapsteps how did you handle the layout shift with the padding? I need to align the items vertically with my grid. |
I added 10px of padding to the inner div and the following to the outer wrapper as - in my case - inline styles:
Hope that helps :) |
@mapsteps thx, that didn't work for me... Just made grid variante with adding the padding for with and max-width, quiet similar to your solution but without a negative margin. |
Hey @christianwalter, I just realized that I didn't add that to the outer wrapper but instead to another wrapper that's around the entire gallery. |
+1 for this requirement as well. Will be running through some tests on my side to see if I can implement a PR for this similar to @cinkagan's above but without the formatting. @gilbitron Are you willing to merge if I can PR a working copy ideally with tests? |
@DIntriglia Sure happy to merge a working PR with tests 👍 |
Hello, I don't know how to create gaps anymore? I need to have them lined up. Thank you so much |
@cinkagan, @DIntriglia any update on this? This library is essentially perfect besides the lack of a gap parameter and it's sad to know that a fix essentially exists, we're just waiting on a PR. Thanks! |
@briannehinchliffe I apologize. I forgot to follow up and actually forget the original reason of me using this library. I will need to look in my projects and see if I can find how I solved the issue. |
Just created a new PR based on #10 – This should resolve the issue while keeping the project clean. |
@DIntriglia no need to apologize! I appreciate you taking a look at this again! |
@gilbitron Would love if you had a minute to review #18 with @DIntriglia's great work! Thanks so much 😄 |
Is it possible to set gap parameter? I tried adding it with css, but it breaks the grid
The text was updated successfully, but these errors were encountered: