Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect failure and provide suggestions #1213

Open
onoter opened this issue Aug 14, 2023 · 2 comments
Open

Detect failure and provide suggestions #1213

onoter opened this issue Aug 14, 2023 · 2 comments

Comments

@onoter
Copy link

onoter commented Aug 14, 2023

Is your feature request related to a problem? Please describe.
Saving pages in sspai like this one will have formatting issues. After that happened, I did't know what caused the problem and tried other browsers and tried enabling and disabling different options, which caused a lot of headache.

Luckily, this time I found the solution here in this repo. But I wish the extension could detect failures and auto suggest solutions.

Describe the solution you'd like
I wish the extension could detect failure caused by hotlink protection(or anything else in general), and show the user what could be the problem and what could be the solution.

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Aug 16, 2023

Thanks for the suggestion. I have very mixed feelings about the feasibility of this feature. For example, it exists in "Save Page WE", I tested it and I find it generates a lot of false positives, which is a pain. The problem is that web pages are full of errors of this type, but that doesn't prevent them from working properly most of the cases because they are not visible or because bugs became features. In other words, it seems complicated to distinguish between "normal" and "unexpected" errors.

BTW, this particular option will disappear in Chrome soon when I will be forced to migrate the extension to MV3. It means that images on sspai or weibo won't be saved anymore. It will continue to work in Firefox though.

@onoter
Copy link
Author

onoter commented Aug 17, 2023

Yeah, false positive will be a headache too. Overall, this kind of problem is quite rare using SingleFile.

BTW, good to know it will continue to work in Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants