Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Site access > Allow this extension to read and change all your data on websites you visit to On click breaks SingleFile (Chromium-based browsers) #894

Open
keks24 opened this issue Mar 14, 2022 · 2 comments

Comments

@keks24
Copy link

keks24 commented Mar 14, 2022

Describe the bug
Saved pages of stackoverflow.com are not formatted properly.

To Reproduce
Steps to reproduce the behavior:

  1. Import the configuration file stackoverflow_profile_settings.json.txt
  2. Go to this StackOverflow page
  3. Right click the extension icon.
  4. Navigate to Save page with profile - stackoverflow.
  5. In the Save As prompt, click on Save.
  6. Open the saved HTML file.

Expected behavior
The page layout should be the same as the original.

Screenshots
It should look like this:

Original

screencapture-stackoverflow-questions-37040798-how-do-you-use-youtube-dl-to-download-live-streams-that-are-live-2022-03-14-20_25_19

https://stackoverflow.com/questions/37040798/how-do-you-use-youtube-dl-to-download-live-streams-that-are-live

But it looks like this:

Saved with SingleFile

screencapture-file-home-ramon-downloads-d88babf2-7e11-4427-a441-247d2126f784-html-2022-03-14-20_33_09

d88babf2-7e11-4427-a441-247d2126f784.html.txt

Environment

  • OS:
$ uname --all
Linux <some_hostname> 5.15.26-gentoo #1 SMP Mon Mar 14 12:06:26 CET 2022 x86_64 Intel(R) Core(TM) i5-3450 CPU @ 3.10GHz GenuineIntel GNU/Linux
  • Browser: ungoogled-chromium
  • Version
$ chromium --version
Chromium 99.0.4844.51
  • USE flags
$ equery uses ungoogled-chromium
[ Legend : U - final flag setting for installation]
[        : I - package is installed with flag     ]
[ Colors : set, unset                             ]
 * Found these USE flags for www-client/ungoogled-chromium-99.0.4844.51-r1:
 U I
 - - cfi                : Build with CFI (Control Flow Integrity) enabled. It requires "-stdlib=libc++", see #40 for more details.
 + + clang              : Use Clang compiler instead of GCC
 - - convert-dict       : Patch and build the convert_dict utility. The script will be installed into /usr/lib64/chromium-browser/update-dicts.sh. More info here:
                          https://github.com/Eloston/ungoogled-chromium/issues/188#issuecomment-444752907
 + + cups               : Add support for CUPS (Common Unix Printing System)
 - - custom-cflags      : Build with user-specified CFLAGS (unsupported)
 - - debug              : Enable DCHECK feature with severity configurable at runtime. Mostly intended for debugging and development, NOT RECOMMENDED for general use.
 - - enable-driver      : Build chromedriver
 - - gtk4               : Build with GTK4 headers.
 - - hangouts           : Enable support for Google Hangouts features such as screen sharing
 - - headless           : Build Ozone only with headless backend, NOT RECOMMENDED for general uses
 - - js-type-check      : Enable JavaScript type-checking for Chrome's web technology-based UI. Requires Java.
 - - kerberos           : Add kerberos support
 - - l10n_am            : Amharic
 - - l10n_ar            : Arabic
 - - l10n_bg            : Bulgarian
 - - l10n_bn            : Bengali
 - - l10n_ca            : Catalan
 - - l10n_cs            : Czech
 - - l10n_da            : Danish
 - - l10n_de            : German
 - - l10n_el            : Modern Greek
 + + l10n_en-GB         : English (United Kingdom)
 - - l10n_es            : Spanish
 - - l10n_es-419        : Spanish (Latin America)
 - - l10n_et            : Estonian
 - - l10n_fa            : Persian
 - - l10n_fi            : Finnish
 - - l10n_fil           : Filipino
 - - l10n_fr            : French
 - - l10n_gu            : Gujarati
 - - l10n_he            : Hebrew
 - - l10n_hi            : Hindi
 - - l10n_hr            : Croatian
 - - l10n_hu            : Hungarian
 - - l10n_id            : Indonesian
 - - l10n_it            : Italian
 - - l10n_ja            : Japanese
 - - l10n_kn            : Kannada
 - - l10n_ko            : Korean
 - - l10n_lt            : Lithuanian
 - - l10n_lv            : Latvian
 - - l10n_ml            : Malayalam
 - - l10n_mr            : Marathi
 - - l10n_ms            : Malay (macrolanguage)
 - - l10n_nb            : Norwegian Bokmål
 - - l10n_nl            : Dutch
 - - l10n_pl            : Polish
 - - l10n_pt-BR         : Portuguese (Brazil)
 - - l10n_pt-PT         : Portuguese (Portugal)
 - - l10n_ro            : Romanian
 - - l10n_ru            : Russian
 - - l10n_sk            : Slovak
 - - l10n_sl            : Slovenian
 - - l10n_sr            : Serbian
 - - l10n_sv            : Swedish
 - - l10n_sw            : Swahili (macrolanguage)
 - - l10n_ta            : Tamil
 - - l10n_te            : Telugu
 - - l10n_th            : Thai
 - - l10n_tr            : Turkish
 - - l10n_uk            : Ukrainian
 - - l10n_vi            : Vietnamese
 - - l10n_zh-CN         : Chinese (China)
 - - l10n_zh-TW         : Chinese (Taiwan)
 + + official           : Enable Official build instead of Developer build.
 + + optimize-thinlto   : Whether to enable ThinLTO optimizations. Turning ThinLTO optimizations on can substantially increase link time and binary size, but they generally also make binaries a fair bit faster.
 + + optimize-webui     : Optimize parts of Chromium's UI written with web technologies (HTML/CSS/JS) for runtime performance purposes. This does more work at compile time for speed benefits at runtime.
 - - pgo                : Enable PGO. Requires clang and bundled binary profile data in sources tree.
 - - pic                : Disable optimized assembly code that is not PIC friendly
 + + proprietary-codecs : Enable proprietary codecs like H.264, MP3
 + + pulseaudio         : Add support for PulseAudio sound server
 - - screencast         : Enable support for remote desktop and screen cast using media-video/pipewire
 - - suid               : Build the SUID sandbox, which is only needed on CONFIG_USER_NS=n kernels
 - - system-ffmpeg      : Use the system media-video/ffmpeg instead of the bundled one
 + + system-harfbuzz    : Use the system media-libs/harfbuzz instead of the bundled one
 + + system-icu         : Use the system dev-libs/icu instead of the bundled one
 + + system-jsoncpp     : Use the system dev-libs/jsoncpp instead of the bundled one
 + + system-libevent    : Use the system dev-libs/libevent instead of the bundled one
 - - system-libvpx      : Use the system media-libs/libvpx instead of the bundled one
 + + system-openh264    : Use the system media-libs/openh264 instead of the bundled one. If disabled, it will restrict USE=bindist.
 - - system-openjpeg    : Use the system-wide media-libs/openjpeg instead of the bundled one. OpenJPEG use are exclusively for Chromium's PDF viewer.
 + + system-png         : Use system libpng instead of the bundled one
 + + system-re2         : Use the system-wide dev-libs/re2 instead of the bundled one
 + + thinlto            : Build with ThinLTO support. LTO (Link Time Optimization) achieves better runtime performance through whole-program analysis and cross-module optimization (highly recommended).
 - - vaapi              : Enable Video Acceleration API for hardware decoding
 + + vdpau              : Enable the Video Decode and Presentation API for Unix acceleration interface
 - - wayland            : Enable dev-libs/wayland backend
 - - widevine           : Unsupported closed-source DRM capability (required by Netflix VOD)
  • SingleFile version: 1.19.34

Additional context
None.

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Mar 15, 2022

Thank you for the detailed report. Unfortunately, I was not able to reproduce the issue by following the procedure you described. On my end, all the resources are properly included in the page. I did my tests on Windows 10 Pro (64-bit) with Chrome 99.0.4844.51 and the version 1.19.34 of SingleFile.
However, I suspect your issue is related to the fact that the setting "Site access > Allow this extension to read and change all your data on websites you visit" would not be set to "On all sites" here: chrome://extensions/?id=mpiodijhokgodhhofbcjdecpffjipkle`. It seems this feature is somewhat broken.

@keks24
Copy link
Author

keks24 commented Mar 15, 2022

Thanks for the quick reply!

Indeed, changing the extension setting Allow this extension to read and change all your data on websites that you visit: to On all sites fixes the issue.

Using the option On click or On specific sites with *://stackoverflow.com/* breaks the layout like above.

@gildas-lormeau gildas-lormeau changed the title StackOverflow pages are not formatted properly Setting Site access > Allow this extension to read and change all your data on websites you visit to On click breaks SingleFile (Chromium-based browsers) Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants