Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events #27

Merged
merged 12 commits into from
Oct 25, 2024
Merged

Events #27

merged 12 commits into from
Oct 25, 2024

Conversation

eudago
Copy link
Member

@eudago eudago commented Sep 25, 2023

No description provided.

@vercel
Copy link

vercel bot commented Sep 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gironajs-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 7:40pm

@eudago eudago marked this pull request as ready for review January 4, 2024 17:53
@eudago eudago requested a review from a team as a code owner January 4, 2024 17:53
@aleix10kst
Copy link
Contributor

Bona feina!
Una petita cosa: hem vist que consumeixes l'API de Github amb Graphql i Apollo Client. Què et semblaria canviar-ho a REST o mantenir Graphql però fer un POST directament tal i com s'ensenya aquí? És més que res per no afegir dues dependències.
Si no vols fer-ho tu, ho podem fer o jo o en @llorenspujol

@eudago
Copy link
Member Author

eudago commented Jan 31, 2024

Bona feina! Una petita cosa: hem vist que consumeixes l'API de Github amb Graphql i Apollo Client. Què et semblaria canviar-ho a REST o mantenir Graphql però fer un POST directament tal i com s'ensenya aquí? És més que res per no afegir dues dependències. Si no vols fer-ho tu, ho podem fer o jo o en @llorenspujol

Vosaltres mateixos!

@llorenspujol
refactor: removed apollo client and grapqhl dependencies. Instead use…
e5f91fa 
… a simple POST request

feat: Show only the open issues
@eudago eudago merged commit aec3066 into main Oct 25, 2024
3 checks passed
@eudago eudago deleted the events branch October 25, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eudago @aleix10kst @llorenspujol