From 62c9e529ecad6143ced53c3c75fc9c307577ec39 Mon Sep 17 00:00:00 2001 From: Wataru Ono Date: Wed, 9 Feb 2022 19:56:48 +0900 Subject: [PATCH 1/5] =?UTF-8?q?refactor:=20List=20=E3=82=92=20Stack=20?= =?UTF-8?q?=E3=81=AB=E7=BD=AE=E3=81=8D=E6=8F=9B=E3=81=88?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Stack の方が適切だと判断したため --- src/components/review/CommentListItem.tsx | 7 ++++--- src/components/review/Widget.tsx | 6 +++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/components/review/CommentListItem.tsx b/src/components/review/CommentListItem.tsx index 26b119fb..99ded09f 100644 --- a/src/components/review/CommentListItem.tsx +++ b/src/components/review/CommentListItem.tsx @@ -1,5 +1,6 @@ import { Avatar } from "@chakra-ui/avatar"; -import { Grid, GridItem, ListItem, Text } from "@chakra-ui/layout"; +import { Grid, GridItem, Text } from "@chakra-ui/layout"; +import { Box } from "@chakra-ui/react"; import ChakraUIRenderer from "chakra-ui-markdown-renderer"; import ReactMarkdown from "react-markdown"; import remarkGfm from "remark-gfm"; @@ -14,7 +15,7 @@ type Props = { const CommentListItem = ({ author, avatarUrl, body }: Props) => { return ( - + @@ -32,7 +33,7 @@ const CommentListItem = ({ author, avatarUrl, body }: Props) => { - + ); }; diff --git a/src/components/review/Widget.tsx b/src/components/review/Widget.tsx index 395b00dc..c7602561 100644 --- a/src/components/review/Widget.tsx +++ b/src/components/review/Widget.tsx @@ -1,4 +1,4 @@ -import { Box, Button, Flex, List, Spacer, Textarea } from "@chakra-ui/react"; +import { Box, Button, Flex, Spacer, Textarea, Stack } from "@chakra-ui/react"; import React, { ChangeEvent, useCallback } from "react"; import CommentListItem from "@/components/review/CommentListItem"; @@ -41,7 +41,7 @@ const Widget = ({ return ( {comments && ( - + {comments.map((comment, index) => { return ( ); })} - + )} {isWriting && ( <> From 10b7dc2181f10e7b40e5a327d4bc167c0173567e Mon Sep 17 00:00:00 2001 From: Wataru Ono Date: Wed, 9 Feb 2022 19:58:04 +0900 Subject: [PATCH 2/5] =?UTF-8?q?refactor:=20=E3=82=A4=E3=83=B3=E3=83=9D?= =?UTF-8?q?=E3=83=BC=E3=83=88=E3=81=AE=E7=B5=B1=E5=90=88?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 冗長だから --- src/components/review/CommentListItem.tsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/components/review/CommentListItem.tsx b/src/components/review/CommentListItem.tsx index 99ded09f..69d230b8 100644 --- a/src/components/review/CommentListItem.tsx +++ b/src/components/review/CommentListItem.tsx @@ -1,6 +1,5 @@ import { Avatar } from "@chakra-ui/avatar"; -import { Grid, GridItem, Text } from "@chakra-ui/layout"; -import { Box } from "@chakra-ui/react"; +import { Grid, GridItem, Text , Box } from "@chakra-ui/layout"; import ChakraUIRenderer from "chakra-ui-markdown-renderer"; import ReactMarkdown from "react-markdown"; import remarkGfm from "remark-gfm"; From 4d0e77e8614da315c1c336ceb33cccb211f93ddd Mon Sep 17 00:00:00 2001 From: Wataru Ono Date: Fri, 11 Feb 2022 15:11:23 +0900 Subject: [PATCH 3/5] =?UTF-8?q?refactor:=20Stack=20=E3=81=AB=20direction?= =?UTF-8?q?=20=E3=82=92=E6=8C=87=E5=AE=9A?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 無駄な思考を減らすため --- src/components/review/Widget.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/review/Widget.tsx b/src/components/review/Widget.tsx index c7602561..ba50c391 100644 --- a/src/components/review/Widget.tsx +++ b/src/components/review/Widget.tsx @@ -41,7 +41,7 @@ const Widget = ({ return ( {comments && ( - + {comments.map((comment, index) => { return ( Date: Fri, 11 Feb 2022 16:39:51 +0900 Subject: [PATCH 4/5] =?UTF-8?q?style:=20Stack=20=E3=82=92=20Widget=20?= =?UTF-8?q?=E5=85=A8=E4=BD=93=E3=81=AB=E9=81=A9=E7=94=A8?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/components/review/Widget.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/components/review/Widget.tsx b/src/components/review/Widget.tsx index ba50c391..76c5f73c 100644 --- a/src/components/review/Widget.tsx +++ b/src/components/review/Widget.tsx @@ -1,4 +1,4 @@ -import { Box, Button, Flex, Spacer, Textarea, Stack } from "@chakra-ui/react"; +import { Button, Flex, Spacer, Textarea, Stack } from "@chakra-ui/react"; import React, { ChangeEvent, useCallback } from "react"; import CommentListItem from "@/components/review/CommentListItem"; @@ -39,9 +39,9 @@ const Widget = ({ }, [onSubmit, changeKey]); return ( - + {comments && ( - + <> {comments.map((comment, index) => { return ( ); })} - + )} {isWriting && ( <> @@ -65,7 +65,7 @@ const Widget = ({ )} - + ); }; From 65da1ff7fe68f9d8edb3d8faa62d529682767669 Mon Sep 17 00:00:00 2001 From: Wataru Ono Date: Fri, 11 Feb 2022 16:40:02 +0900 Subject: [PATCH 5/5] =?UTF-8?q?refactor:=20=E3=82=AB=E3=83=B3=E3=83=9E?= =?UTF-8?q?=E4=BD=8D=E7=BD=AE=E3=81=AE=E4=BF=AE=E6=AD=A3?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/components/review/CommentListItem.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/review/CommentListItem.tsx b/src/components/review/CommentListItem.tsx index 69d230b8..abe97507 100644 --- a/src/components/review/CommentListItem.tsx +++ b/src/components/review/CommentListItem.tsx @@ -1,5 +1,5 @@ import { Avatar } from "@chakra-ui/avatar"; -import { Grid, GridItem, Text , Box } from "@chakra-ui/layout"; +import { Grid, GridItem, Text, Box } from "@chakra-ui/layout"; import ChakraUIRenderer from "chakra-ui-markdown-renderer"; import ReactMarkdown from "react-markdown"; import remarkGfm from "remark-gfm";