Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Feature Request - Override Credit GitButler at a project level #5660

Open
GordonBeeming opened this issue Nov 25, 2024 · 3 comments
Open
Labels
new feature An entirely new featuer UI Any broken visuals like layouts, colors etc.

Comments

@GordonBeeming
Copy link
Contributor

Currently, the Credit GitButler as the committer flag is at a global/profile level

GB-Screenshot 2024-11-25 at 17 45 33@2x

and it would be great to override this at a project level for some where you may need to have it off for some organisation repositories based on repo policies like required full signed commits or approved authors only

GB-Screenshot 2024-11-25 at 17 46 46@2x

@Byron Byron added new feature An entirely new featuer UI Any broken visuals like layouts, colors etc. labels Nov 25, 2024
@Byron
Copy link
Collaborator

Byron commented Nov 25, 2024

Thanks again for sharing!

Even though I perfectly agree, this makes me think about how GitButler should integrate settings that affect the way commits are done. Git already offers to configure everything very flexibly, and maybe it would be most intuitive if it would put this into [gitbutler] git configuration instead? That way it can naturally be overridden on a per-project with the usual means, e.g. includeIf, which would be most intuitive to me.
If changes are made in the UI, they would either affect the global git configuration file, or the repository configuration.

What's more important is that this kind of setting could then always act like this, i.e. have a global and a repository-local version of it, solving the entire class of problem, maybe.

CC @PavelLaptev and @krlvi .

@GordonBeeming
Copy link
Contributor Author

GordonBeeming commented Nov 25, 2024

I think it would be great if there was integration with gitconfig, then I can configure it once and add it to my alias's to my config to change per repo when needed which is part of my normal flow already that controls my normal signing settings

EDIT: I've added gitbutler.signCommits to my alias, so maybe it will auto set for my repos going forward 😎

@GordonBeeming
Copy link
Contributor Author

GordonBeeming commented Nov 25, 2024

EDIT: Nevermind... it's setting the same config already 😂.
Which maybe makes #5658 even weirder 🤔

I guess the only change here would be looking for that config and then switching on this flag?

[gitbutler]
	signCommits = true

Ignore below... but leaving for context for the settings if anyone else reads this later

Looking at it more, some settings would not even need to be in the [gitbutler] section, as the UI currently has a duplicate of my local settings 😅

GB-Screenshot 2024-11-25 at 20 37 09@2x

GB-Screenshot 2024-11-25 at 20 41 04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature An entirely new featuer UI Any broken visuals like layouts, colors etc.
Projects
None yet
Development

No branches or pull requests

2 participants