"Unapply and drop changes" shouldn't be shown when there are no changes

[hferreiro]

Version

0.13.17

Operating System

macOS

Distribution Method

dmg (Apple Silicon)

Describe the issue

On a new empty lane, "Unapply" and "Unapply and drop changes" do the same thing. The latter shouldn't be shown in that case.

How to reproduce

No response

Expected behavior

No response

Relevant log output

No response

[Byron]

Thanks a lot for reporting!

It does indeed seem like "Unapply" is the only thing one would show there.
CC @PavelLaptev

[PavelLaptev]

Related issue #5586

[PavelLaptev]

Thank you for your feedback, @hferreiro.
There is definitely an ambiguity here that I’ve been struggling with too.
@krlvi @Caleb-T-Owens, we’ve discussed this, but we decided to postpone it. What do you think?

Here is my proposal:

• If there are no changes — disable "unapply and drop changes".
• If it's a new branch that hasn’t been pushed and doesn’t have any changes, disable "unapply", and instead of "unapply and drop changes" use "remove".

[hferreiro]

That makes a lot of sense, thanks.