Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applying to a round is not working #3169

Closed
boudra opened this issue Mar 21, 2024 · 2 comments
Closed

applying to a round is not working #3169

boudra opened this issue Mar 21, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@boudra
Copy link
Contributor

boudra commented Mar 21, 2024

this is applying to a round in avalanche using an optimism project

https://builder-git-allo-migration-grants-stack.vercel.app/#/chains/43114/rounds/1

  1. ensure the UI doesn't hang and handles errors properly
  2. fix the actual issue
Screenshot 2024-03-21 at 14 34 46
@boudra boudra added the bug Something isn't working label Mar 21, 2024
@boudra boudra moved this to Todo in Grants Lab Mar 21, 2024
@thelostone-mc thelostone-mc moved this from Todo to In Progress in Grants Lab Mar 21, 2024
@thelostone-mc
Copy link
Member

thelostone-mc commented Mar 21, 2024

Fixed at 8272a79

@thelostone-mc
Copy link
Member

So here is what we found out.
The anchor address on optimism is different from the ones on the other chains for a given project despite having the same project id.
This is something along the lines what we were concerned for zk-era

We created a project on optimism and created linked profiles on scrolll and avalanche. Then we checked the anchor address and notices that while all projects have the same projectId, The anchor address for scroll and avalanche were same but different from what optimism had.

{
  projects(condition: {id: "0x5f7b5be0f364eab38af5468c2dd16c7926101d51752ce1ef6a66f57f7aefb07b", tags: "allo-v2"}) {
    id
    chainId
    anchorAddress
    name
    nonce
  }
}

The fix: we would have to update builder to ensure we pick the right projects anchor address and do away with the assumption that the anchor address is the same.

Why does this happen :
ethereum-optimism/contracts#306
OVM bytecode is different from EVM bytecode
Create2 addresses on Optimism would be different from Create2 addresses in Ethereum.

**Downside: **

  • No downside apart from projects having different anchor address
  • Extra work to update builder to always use the right anchor (low effort)

Upside

  • The solution we put in here on builder will unblock era

@thelostone-mc thelostone-mc moved this from In Progress to PR Review in Grants Lab Mar 21, 2024
@thelostone-mc thelostone-mc moved this from PR Review to Live in Grants Lab Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants