Merge pull request #34 from github-copilot-resources/fix/acceptance-r…

…ate-calc Refactor acceptance rate calculation in MetricsViewer.vue
github-copilot-resources · May 31, 2024 · 32be12f · 32be12f
2 parents c5ccd1d + fb4e70f
commit 32be12f
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/components/MetricsViewer.vue b/src/components/MetricsViewer.vue
@@ -252,14 +252,12 @@ export default defineComponent({
         }
       ]
     };
-
-    let sum = 0;
+    
     const acceptanceRates = data.map((m: Metrics) => {
       const rate = m.total_lines_suggested !== 0 ? (m.total_lines_accepted / m.total_lines_suggested) * 100 : 0;
-      sum += rate;
       return rate;
     });
-    acceptanceRateAverage.value = sum / data.length;
+    
 
     acceptanceRateChartData.value = {
       labels: data.map((m: Metrics) => m.day),
@@ -274,6 +272,12 @@ export default defineComponent({
         }
       ]
     };
+    
+    if(cumulativeNumberSuggestions.value === 0){
+      acceptanceRateAverage.value = 0;
+    } else {
+      acceptanceRateAverage.value = cumulativeNumberAcceptances.value / cumulativeNumberSuggestions.value * 100;
+    }
 
     totalActiveUsersChartData.value = {
       labels: data.map((m: Metrics) => m.day),