implement package io5 #886
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…additional-cert-rules
There was a problem hiding this comment.
Pull Request Overview
This pull request implements package IO5 by adding new query tests and documentation for CERT rules FIO03-C, FIO21-C, and POS30-C. Key changes include:
- New test cases for FIO21-C and FIO03-C demonstrating compliant and noncompliant file operations.
- Updated markdown documentation for POS30-C, FIO21-C (including two queries on temporary file creation), and FIO03-C.
- A modification to qlpack.yml to set a default suite file.
Reviewed Changes
Copilot reviewed 26 out of 39 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| c/cert/test/rules/FIO21-C/test.c | Added test cases illustrating noncompliant and compliant file operations related to temporary file creation. |
| c/cert/test/rules/FIO03-C/test.c | Added test examples for secure and insecure file opening functions. |
| c/cert/src/rules/POS30-C/IncorrectNullTerminationOfReadlink.md | Updated documentation for correct use of readlink(). |
| c/cert/src/rules/FIO21-C/PossiblyPredictableTemporaryFileCreation.md | New documentation describing the risks of predictable temporary file names. |
| c/cert/src/rules/FIO21-C/ExploitableTemporaryFileCreation.md | New documentation on exploitable temporary file creation scenarios. |
| c/cert/src/rules/FIO03-C/FopenWithNonExclusiveFileCreationMode.md | New documentation on securely opening files without unintended file creation. |
| c/cert/src/qlpack.yml | Updated with a default suite file for the package. |
Files not reviewed (13)
- c/cert/src/codeql-suites/cert-c-default.qls: Language not supported
- c/cert/src/codeql-suites/cert-c-recommendation.qls: Language not supported
- c/cert/src/codeql-suites/cert-default.qls: Language not supported
- c/cert/src/rules/FIO03-C/FopenWithNonExclusiveFileCreationMode.ql: Language not supported
- c/cert/src/rules/FIO21-C/ExploitableTemporaryFileCreation.ql: Language not supported
- c/cert/src/rules/FIO21-C/PossiblyPredictableTemporaryFileCreation.ql: Language not supported
- c/cert/src/rules/POS30-C/IncorrectNullTerminationOfReadlink.ql: Language not supported
- c/cert/test/rules/FIO03-C/FopenWithNonExclusiveFileCreationMode.expected: Language not supported
- c/cert/test/rules/FIO03-C/FopenWithNonExclusiveFileCreationMode.qlref: Language not supported
- c/cert/test/rules/FIO21-C/ExploitableTemporaryFileCreation.expected: Language not supported
- c/cert/test/rules/FIO21-C/ExploitableTemporaryFileCreation.qlref: Language not supported
- c/cert/test/rules/FIO21-C/PossiblyPredictableTemporaryFileCreation.expected: Language not supported
- c/cert/test/rules/FIO21-C/PossiblyPredictableTemporaryFileCreation.qlref: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement package IO5
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
FIO03-CFIO21-CPOS30-CRelease change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.