diff --git a/java/ql/src/Security/CWE/CWE-352/CsrfUnprotectedRequestType.qhelp b/java/ql/src/Security/CWE/CWE-352/CsrfUnprotectedRequestType.qhelp index c7cfb14bd29f..08df43e220d1 100644 --- a/java/ql/src/Security/CWE/CWE-352/CsrfUnprotectedRequestType.qhelp +++ b/java/ql/src/Security/CWE/CWE-352/CsrfUnprotectedRequestType.qhelp @@ -3,7 +3,7 @@

When you set up a web server to receive a request from a client without any mechanism -for verifying that it was intentionally sent, then it is vulnerable to a Cross Site Request +for verifying that it was intentionally sent, then it is vulnerable to a Cross-Site Request Forgery (CSRF) attack. An attacker can trick a client into making an unintended request to the web server that will be treated as an authentic request. This can be done via a URL, image load, XMLHttpRequest, etc. and can result in exposure of data or unintended code execution.

@@ -17,13 +17,13 @@ should only perform read-only operations and should not be used for actions that state.

This query currently supports the Spring and Stapler web frameworks. Spring provides default CSRF protection -for all unsafe HTTP methods. Stapler provides default CSRF protection for the POST method.

+for all unsafe HTTP methods whereas Stapler provides default CSRF protection for the POST method.

The following examples show Spring request handlers allowing safe HTTP request methods for state-changing actions. Since safe HTTP request methods do not have default CSRF protection in Spring, they should not be used when modifying -application state. Instead use one of the unsafe HTTP methods which Spring default-protects from CSRF.

+application state. Instead, use one of the unsafe HTTP methods which Spring default-protects from CSRF.

@@ -31,7 +31,7 @@ application state. Instead use one of the unsafe HTTP methods which Spring defau

The following examples show Stapler web methods allowing safe HTTP request methods for state-changing actions. Since safe HTTP request methods do not have default CSRF protection in Stapler, they should not be used when modifying -application state. Instead use the POST method which Stapler default-protects from CSRF.

+application state. Instead, use the POST method which Stapler default-protects from CSRF.