diff --git a/content/actions/about-github-actions/about-continuous-deployment.md b/content/actions/about-github-actions/about-continuous-deployment-with-github-actions.md similarity index 96% rename from content/actions/about-github-actions/about-continuous-deployment.md rename to content/actions/about-github-actions/about-continuous-deployment-with-github-actions.md index 558a0c843ccb..6150dd6b7b39 100644 --- a/content/actions/about-github-actions/about-continuous-deployment.md +++ b/content/actions/about-github-actions/about-continuous-deployment-with-github-actions.md @@ -1,5 +1,5 @@ --- -title: About continuous deployment +title: About continuous deployment with GitHub Actions shortTitle: Continuous deployment intro: 'You can create custom continuous deployment (CD) workflows directly in your {% data variables.product.prodname_dotcom %} repository with {% data variables.product.prodname_actions %}.' versions: @@ -11,6 +11,7 @@ redirect_from: - /actions/deployment/about-continuous-deployment - /actions/deployment/about-deployments/about-continuous-deployment - /actions/deployment/about-deployments + - /actions/about-github-actions/about-continuous-deployment topics: - CD --- diff --git a/content/actions/about-github-actions/about-continuous-integration.md b/content/actions/about-github-actions/about-continuous-integration-with-github-actions.md similarity index 97% rename from content/actions/about-github-actions/about-continuous-integration.md rename to content/actions/about-github-actions/about-continuous-integration-with-github-actions.md index 60fb7abbdcc8..d475aeb1ee97 100644 --- a/content/actions/about-github-actions/about-continuous-integration.md +++ b/content/actions/about-github-actions/about-continuous-integration-with-github-actions.md @@ -1,5 +1,5 @@ --- -title: About continuous integration +title: About continuous integration with GitHub Actions intro: 'You can create custom continuous integration (CI) workflows directly in your {% data variables.product.prodname_dotcom %} repository with {% data variables.product.prodname_actions %}.' redirect_from: - /articles/about-continuous-integration @@ -8,6 +8,7 @@ redirect_from: - /actions/building-and-testing-code-with-continuous-integration/about-continuous-integration - /actions/guides/about-continuous-integration - /actions/automating-builds-and-tests/about-continuous-integration + - /actions/about-github-actions/about-continuous-integration versions: fpt: '*' ghes: '*' diff --git a/content/actions/about-github-actions/index.md b/content/actions/about-github-actions/index.md index fc8b1a2dedc8..afac6b532280 100644 --- a/content/actions/about-github-actions/index.md +++ b/content/actions/about-github-actions/index.md @@ -8,7 +8,7 @@ versions: ghec: '*' children: - /understanding-github-actions - - /about-continuous-integration - - /about-continuous-deployment + - /about-continuous-integration-with-github-actions + - /about-continuous-deployment-with-github-actions --- diff --git a/content/actions/guides.md b/content/actions/guides.md index 53d266ec8f47..2a3a81b7a618 100644 --- a/content/actions/guides.md +++ b/content/actions/guides.md @@ -23,7 +23,7 @@ includeGuides: - /actions/use-cases-and-examples/publishing-packages/about-packaging-with-github-actions - /actions/use-cases-and-examples/publishing-packages/publishing-docker-images - /actions/writing-workflows/choosing-what-your-workflow-does/caching-dependencies-to-speed-up-workflows - - /actions/about-github-actions/about-continuous-integration + - /actions/about-github-actions/about-continuous-integration-with-github-actions - /actions/use-cases-and-examples/building-and-testing/building-and-testing-powershell - /actions/use-cases-and-examples/building-and-testing/building-and-testing-ruby - /actions/use-cases-and-examples/building-and-testing/building-and-testing-java-with-maven @@ -35,7 +35,7 @@ includeGuides: - /actions/use-cases-and-examples/publishing-packages/publishing-nodejs-packages - /actions/use-cases-and-examples/publishing-packages/publishing-java-packages-with-maven - /actions/use-cases-and-examples/publishing-packages/publishing-java-packages-with-gradle - - /actions/writing-workflows/choosing-what-your-workflow-does/storing-workflow-data-as-artifacts + - /actions/writing-workflows/choosing-what-your-workflow-does/storing-and-sharing-data-from-a-workflow - /actions/use-cases-and-examples/using-containerized-services/about-service-containers - /actions/use-cases-and-examples/using-containerized-services/creating-redis-service-containers - /actions/use-cases-and-examples/using-containerized-services/creating-postgresql-service-containers diff --git a/content/actions/index.md b/content/actions/index.md index feef36459549..d60236fb045e 100644 --- a/content/actions/index.md +++ b/content/actions/index.md @@ -9,7 +9,7 @@ featuredLinks: startHere: - /actions/writing-workflows - /actions/use-cases-and-examples - - /actions/about-github-actions/about-continuous-integration + - /actions/about-github-actions/about-continuous-integration-with-github-actions - /actions/use-cases-and-examples/deploying/deploying-with-github-actions - /actions/use-cases-and-examples/publishing-packages/about-packaging-with-github-actions - /actions/monitoring-and-troubleshooting-workflows @@ -50,3 +50,4 @@ children: - /administering-github-actions - /guides --- + diff --git a/content/actions/writing-workflows/choosing-what-your-workflow-does/contexts.md b/content/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs.md similarity index 99% rename from content/actions/writing-workflows/choosing-what-your-workflow-does/contexts.md rename to content/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs.md index 14156bfe4271..ff2544a3bb48 100644 --- a/content/actions/writing-workflows/choosing-what-your-workflow-does/contexts.md +++ b/content/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs.md @@ -1,5 +1,5 @@ --- -title: Contexts +title: Accessing contextual information about workflow runs shortTitle: Contexts intro: You can access context information in workflows and actions. redirect_from: @@ -9,6 +9,7 @@ redirect_from: - /actions/reference/contexts-and-expression-syntax-for-github-actions - /actions/reference/context-and-expression-syntax-for-github-actions - /actions/learn-github-actions/contexts + - /actions/writing-workflows/choosing-what-your-workflow-does/contexts versions: fpt: '*' ghes: '*' diff --git a/content/actions/writing-workflows/choosing-what-your-workflow-does/using-concurrency.md b/content/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs.md similarity index 91% rename from content/actions/writing-workflows/choosing-what-your-workflow-does/using-concurrency.md rename to content/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs.md index c3fdb1a87d24..2ea67b43254c 100644 --- a/content/actions/writing-workflows/choosing-what-your-workflow-does/using-concurrency.md +++ b/content/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs.md @@ -1,5 +1,5 @@ --- -title: Using concurrency +title: Control the concurrency of workflows and jobs shortTitle: Concurrency intro: Run a single job at a time. versions: @@ -8,6 +8,7 @@ versions: ghec: '*' redirect_from: - /actions/using-jobs/using-concurrency + - /actions/writing-workflows/choosing-what-your-workflow-does/using-concurrency --- {% data reusables.actions.enterprise-github-hosted-runners %} diff --git a/content/actions/writing-workflows/choosing-what-your-workflow-does/assigning-permissions-to-jobs.md b/content/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token.md similarity index 79% rename from content/actions/writing-workflows/choosing-what-your-workflow-does/assigning-permissions-to-jobs.md rename to content/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token.md index 691240d91796..daf742be7c7f 100644 --- a/content/actions/writing-workflows/choosing-what-your-workflow-does/assigning-permissions-to-jobs.md +++ b/content/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token.md @@ -1,6 +1,6 @@ --- -title: Assigning permissions to jobs -shortTitle: Assign permissions to jobs +title: Controlling permissions for `GITHUB_TOKEN` +shortTitle: Permissions for `GITHUB_TOKEN` intro: Modify the default permissions granted to `GITHUB_TOKEN`. versions: fpt: '*' @@ -8,8 +8,12 @@ versions: ghec: '*' redirect_from: - /actions/using-jobs/assigning-permissions-to-jobs + - >- + /actions/writing-workflows/choosing-what-your-workflow-does/assigning-permissions-to-jobs + - >- + /actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github-token --- - + {% data reusables.actions.enterprise-github-hosted-runners %} ## Overview diff --git a/content/actions/writing-workflows/choosing-what-your-workflow-does/expressions.md b/content/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions.md similarity index 99% rename from content/actions/writing-workflows/choosing-what-your-workflow-does/expressions.md rename to content/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions.md index 5518ebe3c391..ad66d9d33346 100644 --- a/content/actions/writing-workflows/choosing-what-your-workflow-does/expressions.md +++ b/content/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions.md @@ -1,5 +1,5 @@ --- -title: Expressions +title: Evaluate expressions in workflows and actions shortTitle: Expressions intro: You can evaluate expressions in workflows and actions. versions: @@ -8,6 +8,7 @@ versions: ghec: '*' redirect_from: - /actions/learn-github-actions/expressions + - /actions/writing-workflows/choosing-what-your-workflow-does/expressions --- {% data reusables.actions.enterprise-github-hosted-runners %} diff --git a/content/actions/writing-workflows/choosing-what-your-workflow-does/index.md b/content/actions/writing-workflows/choosing-what-your-workflow-does/index.md index 48c37341783f..5ae234abe5cb 100644 --- a/content/actions/writing-workflows/choosing-what-your-workflow-does/index.md +++ b/content/actions/writing-workflows/choosing-what-your-workflow-does/index.md @@ -10,20 +10,19 @@ versions: ghec: '*' children: - /using-jobs-in-a-workflow - - /finding-and-customizing-actions + - /using-pre-written-building-blocks-in-your-workflow - /using-github-cli-in-workflows - /workflow-commands-for-github-actions - /adding-scripts-to-your-workflow - - /assigning-permissions-to-jobs - - /expressions - - /variables - - /contexts - - /defining-outputs-for-jobs - - /setting-default-values-for-jobs + - /controlling-permissions-for-github_token + - /evaluate-expressions-in-workflows-and-actions + - /store-information-in-variables + - /accessing-contextual-information-about-workflow-runs + - /passing-information-between-jobs + - /setting-a-default-shell-and-working-directory - /using-environments-for-deployment - - /using-concurrency - - /using-a-matrix-for-your-jobs + - /control-the-concurrency-of-workflows-and-jobs + - /running-variations-of-jobs-in-a-workflow - /caching-dependencies-to-speed-up-workflows - - /storing-workflow-data-as-artifacts + - /storing-and-sharing-data-from-a-workflow --- - diff --git a/content/actions/writing-workflows/choosing-what-your-workflow-does/defining-outputs-for-jobs.md b/content/actions/writing-workflows/choosing-what-your-workflow-does/passing-information-between-jobs.md similarity index 52% rename from content/actions/writing-workflows/choosing-what-your-workflow-does/defining-outputs-for-jobs.md rename to content/actions/writing-workflows/choosing-what-your-workflow-does/passing-information-between-jobs.md index 80c53cae9dbd..eb77388f6a78 100644 --- a/content/actions/writing-workflows/choosing-what-your-workflow-does/defining-outputs-for-jobs.md +++ b/content/actions/writing-workflows/choosing-what-your-workflow-does/passing-information-between-jobs.md @@ -1,15 +1,16 @@ --- -title: Defining outputs for jobs -shortTitle: Define outputs for jobs -intro: Create a map of outputs for your jobs. +title: Passing information between jobs +shortTitle: Pass information +intro: You can define outputs to pass information from one job to another. versions: fpt: '*' ghes: '*' ghec: '*' redirect_from: - /actions/using-jobs/defining-outputs-for-jobs + - /actions/writing-workflows/choosing-what-your-workflow-does/defining-outputs-for-jobs --- - + {% data reusables.actions.enterprise-github-hosted-runners %} ## Overview diff --git a/content/actions/writing-workflows/choosing-what-your-workflow-does/using-a-matrix-for-your-jobs.md b/content/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow.md similarity index 90% rename from content/actions/writing-workflows/choosing-what-your-workflow-does/using-a-matrix-for-your-jobs.md rename to content/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow.md index ecd11fce5a4d..1a2ea51893d9 100644 --- a/content/actions/writing-workflows/choosing-what-your-workflow-does/using-a-matrix-for-your-jobs.md +++ b/content/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow.md @@ -1,6 +1,6 @@ --- -title: Using a matrix for your jobs -shortTitle: Matrices +title: Running variations of jobs in a workflow +shortTitle: Run job variations intro: Create a matrix to define variations for each job. versions: fpt: '*' @@ -10,8 +10,9 @@ redirect_from: - /actions/using-jobs/using-a-build-matrix-for-your-jobs - /actions/using-jobs/using-a-matrix-for-your-jobs - /actions/examples/using-concurrency-expressions-and-a-test-matrix + - /actions/writing-workflows/choosing-what-your-workflow-does/using-a-matrix-for-your-jobs --- - + {% data reusables.actions.enterprise-github-hosted-runners %} ## About matrix strategies diff --git a/content/actions/writing-workflows/choosing-what-your-workflow-does/setting-default-values-for-jobs.md b/content/actions/writing-workflows/choosing-what-your-workflow-does/setting-a-default-shell-and-working-directory.md similarity index 86% rename from content/actions/writing-workflows/choosing-what-your-workflow-does/setting-default-values-for-jobs.md rename to content/actions/writing-workflows/choosing-what-your-workflow-does/setting-a-default-shell-and-working-directory.md index 016d4e60efff..88e76390e230 100644 --- a/content/actions/writing-workflows/choosing-what-your-workflow-does/setting-default-values-for-jobs.md +++ b/content/actions/writing-workflows/choosing-what-your-workflow-does/setting-a-default-shell-and-working-directory.md @@ -1,5 +1,5 @@ --- -title: Setting default values for jobs +title: Setting a default shell and working directory shortTitle: Set default values for jobs intro: 'Define the default settings that will apply to all jobs in the workflow, or all steps in a job.' versions: @@ -8,6 +8,7 @@ versions: ghec: '*' redirect_from: - /actions/using-jobs/setting-default-values-for-jobs + - /actions/writing-workflows/choosing-what-your-workflow-does/setting-default-values-for-jobs --- {% data reusables.actions.enterprise-github-hosted-runners %} diff --git a/content/actions/writing-workflows/choosing-what-your-workflow-does/variables.md b/content/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables.md similarity index 99% rename from content/actions/writing-workflows/choosing-what-your-workflow-does/variables.md rename to content/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables.md index 4457ade05432..e1188a088c7a 100644 --- a/content/actions/writing-workflows/choosing-what-your-workflow-does/variables.md +++ b/content/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables.md @@ -1,5 +1,6 @@ --- -title: Variables +title: Store information in variables +shortTitle: Variables intro: '{% data variables.product.prodname_dotcom %} sets default variables for each {% data variables.product.prodname_actions %} workflow run. You can also set custom variables for use in a single workflow or multiple workflows.' redirect_from: - /github/automating-your-workflow-with-github-actions/using-environment-variables @@ -8,6 +9,7 @@ redirect_from: - /actions/reference/environment-variables - /actions/learn-github-actions/environment-variables - /actions/learn-github-actions/variables + - /actions/writing-workflows/choosing-what-your-workflow-does/variables versions: fpt: '*' ghes: '*' diff --git a/content/actions/writing-workflows/choosing-what-your-workflow-does/storing-workflow-data-as-artifacts.md b/content/actions/writing-workflows/choosing-what-your-workflow-does/storing-and-sharing-data-from-a-workflow.md similarity index 98% rename from content/actions/writing-workflows/choosing-what-your-workflow-does/storing-workflow-data-as-artifacts.md rename to content/actions/writing-workflows/choosing-what-your-workflow-does/storing-and-sharing-data-from-a-workflow.md index 2ae20cf2d665..9d8fa3ec235b 100644 --- a/content/actions/writing-workflows/choosing-what-your-workflow-does/storing-workflow-data-as-artifacts.md +++ b/content/actions/writing-workflows/choosing-what-your-workflow-does/storing-and-sharing-data-from-a-workflow.md @@ -1,5 +1,5 @@ --- -title: Storing workflow data as artifacts +title: Storing and sharing data from a workflow shortTitle: Store artifacts intro: Artifacts allow you to share data between jobs in a workflow and store data once that workflow has completed. redirect_from: @@ -10,6 +10,7 @@ redirect_from: - /actions/guides/storing-workflow-data-as-artifacts - /actions/advanced-guides/storing-workflow-data-as-artifacts - /actions/using-workflows/storing-workflow-data-as-artifacts + - /actions/writing-workflows/choosing-what-your-workflow-does/storing-workflow-data-as-artifacts versions: fpt: '*' ghes: '*' diff --git a/content/actions/writing-workflows/choosing-what-your-workflow-does/finding-and-customizing-actions.md b/content/actions/writing-workflows/choosing-what-your-workflow-does/using-pre-written-building-blocks-in-your-workflow.md similarity index 91% rename from content/actions/writing-workflows/choosing-what-your-workflow-does/finding-and-customizing-actions.md rename to content/actions/writing-workflows/choosing-what-your-workflow-does/using-pre-written-building-blocks-in-your-workflow.md index 40fc194f8cd0..fb94cd9663bf 100644 --- a/content/actions/writing-workflows/choosing-what-your-workflow-does/finding-and-customizing-actions.md +++ b/content/actions/writing-workflows/choosing-what-your-workflow-does/using-pre-written-building-blocks-in-your-workflow.md @@ -1,5 +1,5 @@ --- -title: Finding and customizing actions +title: Using pre-written building blocks in your workflow shortTitle: Find and customize actions intro: 'Actions are the building blocks that power your workflow. A workflow can contain actions created by the community, or you can create your own actions directly within your application''s repository. This guide will show you how to discover, use, and customize actions.' redirect_from: @@ -8,6 +8,7 @@ redirect_from: - /actions/getting-started-with-github-actions/using-actions-from-github-marketplace - /actions/getting-started-with-github-actions/using-community-workflows-and-actions - /actions/learn-github-actions/finding-and-customizing-actions + - /actions/writing-workflows/choosing-what-your-workflow-does/finding-and-customizing-actions versions: fpt: '*' ghes: '*' @@ -21,6 +22,15 @@ topics: ## Overview +You can use pre-written building blocks, called actions, in your workflow. An action is a pre-defined, reusable set of jobs or code that perform specific tasks within a workflow. + +Actions can be: + +* **Reusable**: actions can be used across different workflows and repositories, allowing you to avoid rewriting the same code. +* **Pre-written**: many actions are available in the {% data variables.product.prodname_marketplace %}, covering a wide range of tasks like checking out code, setting up environments, running tests, and deploying applications. +* **Configurable**: you can configure actions with inputs, outputs, and environment variables to tailor them to your specific needs. +* **Community-driven**: you can create your own actions and share them with others or use actions developed by the community. + The actions you use in your workflow can be defined in: * The same repository as your workflow file{% ifversion internal-actions %} diff --git a/data/learning-tracks/actions.yml b/data/learning-tracks/actions.yml index cb3538702287..55f5c22925e6 100644 --- a/data/learning-tracks/actions.yml +++ b/data/learning-tracks/actions.yml @@ -6,7 +6,7 @@ getting_started: guides: - /actions/about-github-actions/understanding-github-actions - >- - /actions/writing-workflows/choosing-what-your-workflow-does/finding-and-customizing-actions + /actions/writing-workflows/choosing-what-your-workflow-does/using-pre-written-building-blocks-in-your-workflow - /actions/writing-workflows/about-workflows - /actions/sharing-automations/reusing-workflows - >- diff --git a/data/ui.yml b/data/ui.yml index b1eda9e3b4c9..e41931591939 100644 --- a/data/ui.yml +++ b/data/ui.yml @@ -63,7 +63,6 @@ survey: additional_feedback: Can you tell us more about your rating? (Optional) optional: Optional required: Required - email_placeholder: 'Example: email@example.com' email_label: Leave your email if we can contact you. (Optional) email_validation: Please enter a valid email address send: Send diff --git a/src/events/components/Survey.module.scss b/src/events/components/Survey.module.scss index df1833bc2545..8edb49c583e1 100644 --- a/src/events/components/Survey.module.scss +++ b/src/events/components/Survey.module.scss @@ -3,13 +3,8 @@ margin: -0.4em; } -.customRadio + label:before { - content: "X"; - color: transparent; - margin: 0px -33px 0px -17px; - padding: 7px 20px 7px 20px; -} - -.customRadio:focus + label:before { - outline: 1px auto -webkit-focus-ring-color; +.customRadio:focus + label { + outline: 2px auto Highlight; // for firefox + outline: 2px auto -webkit-focus-ring-color; + // var(--fgColor-accent, var(--color-accent-fg)) } diff --git a/src/events/components/Survey.tsx b/src/events/components/Survey.tsx index ebaae271facb..b683ce10946d 100644 --- a/src/events/components/Survey.tsx +++ b/src/events/components/Survey.tsx @@ -70,7 +70,7 @@ export const Survey = () => { // readers won't read the error message) so we need to do manual validation // ourselves. useEffect(() => { - const emailRegex = /[^@\s.][^@\s]*@\[?[a-z0-9.-]+\]?/i + const emailRegex = /[^@\s.][^@\s]*@\[?[a-z0-9.-]+\]?\.\[?[a-z0-9.-]+\]?/i if (!email.trim() || emailRegex.test(email)) { setIsEmailError(false) } else { @@ -120,8 +120,8 @@ export const Survey = () => { onChange={(event) => setToken(event.target.value)} /> - {voteState === null && ( -
+ {state !== ViewState.END && ( +
{ /> { />
)} @@ -194,23 +194,21 @@ export const Survey = () => { >

-
+
3 ? 'warn' : '')}> setEmail(event.target.value)} aria-invalid={isEmailError} {...(isEmailError ? { 'aria-describedby': 'email-input-validation' } : {})} /> - {isEmailError && ( + {isEmailError && email.trim().length > 3 && (

{t`email_validation`}

@@ -231,11 +229,7 @@ export const Survey = () => { > {t`cancel`} -
diff --git a/src/fixtures/fixtures/data/ui.yml b/src/fixtures/fixtures/data/ui.yml index b1eda9e3b4c9..e41931591939 100644 --- a/src/fixtures/fixtures/data/ui.yml +++ b/src/fixtures/fixtures/data/ui.yml @@ -63,7 +63,6 @@ survey: additional_feedback: Can you tell us more about your rating? (Optional) optional: Optional required: Required - email_placeholder: 'Example: email@example.com' email_label: Leave your email if we can contact you. (Optional) email_validation: Please enter a valid email address send: Send diff --git a/src/fixtures/fixtures/translations/ja-jp/data/ui.yml b/src/fixtures/fixtures/translations/ja-jp/data/ui.yml index 3d2501813e85..f64490849dbb 100644 --- a/src/fixtures/fixtures/translations/ja-jp/data/ui.yml +++ b/src/fixtures/fixtures/translations/ja-jp/data/ui.yml @@ -55,7 +55,6 @@ survey: comment_no_label: 改善の方法をお知らせください optional: オプション required: 必須 - email_placeholder: email@example.com email_label: さらにお尋ねするためにご連絡してもよろしければ、メール アドレスを入力してください email_validation: 有効な電子メール アドレスを入力してください send: Send diff --git a/src/fixtures/tests/playwright-rendering.spec.ts b/src/fixtures/tests/playwright-rendering.spec.ts index c500934026d9..491fe55c57a0 100644 --- a/src/fixtures/tests/playwright-rendering.spec.ts +++ b/src/fixtures/tests/playwright-rendering.spec.ts @@ -523,8 +523,8 @@ test.describe('survey', () => { await page.locator('[for=survey-comment]').click() await page.locator('[for=survey-comment]').fill('This is a comment') - await page.getByPlaceholder('email@example.com').click() - await page.getByPlaceholder('email@example.com').fill('test@example.com') + await page.locator('[name=survey-email]').click() + await page.locator('[name=survey-email]').fill('test@example.com') await page.getByRole('button', { name: 'Send' }).click() // One for the page view event, one for the thumbs up click, one for // the submission. diff --git a/src/frame/components/page-footer/Contribution.tsx b/src/frame/components/page-footer/Contribution.tsx index 96f6b025b4ef..d5ac781ab884 100644 --- a/src/frame/components/page-footer/Contribution.tsx +++ b/src/frame/components/page-footer/Contribution.tsx @@ -15,7 +15,7 @@ export const Contribution = () => {

{t`title`}

{t`body`}

- + {t`button`}