From 6c054c7d23292694c2c7b2e0be310146fb80bb1f Mon Sep 17 00:00:00 2001 From: Denis Vakulenko <00vakulenko@gmail.com> Date: Thu, 16 May 2024 22:49:45 +0500 Subject: [PATCH 1/4] Clarify the method of selecting several lines for commenting in PR. --- data/reusables/repositories/start-line-comment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/reusables/repositories/start-line-comment.md b/data/reusables/repositories/start-line-comment.md index 7751a21c4d9b..2109650342e5 100644 --- a/data/reusables/repositories/start-line-comment.md +++ b/data/reusables/repositories/start-line-comment.md @@ -1,3 +1,3 @@ -1. Hover over the line of code where you'd like to add a comment, and click the blue comment icon. To add a comment on multiple lines, click and drag to select the range of lines, then click the blue comment icon. +1. Hover over the line of code where you'd like to add a comment, and click the blue comment icon. To add a comment on multiple lines, click on a line in the line number gutter area and drag to select the range of lines, then click the blue comment icon, or initially click on the blue comment icon and drag to select the range of lines. ![Screenshot of a diff in a pull request. Next to a line number, a blue plus icon is highlighted with an orange outline.](/assets/images/help/commits/hover-comment-icon.png) From 1e8f47b9dc72c73e13e076ae39f79c25209fc205 Mon Sep 17 00:00:00 2001 From: Denis Vakulenko <00vakulenko@gmail.com> Date: Sat, 18 May 2024 10:32:29 +0500 Subject: [PATCH 2/4] Add a new list item about comment on multiple lines --- .../commenting-on-a-pull-request.md | 1 + .../reviewing-proposed-changes-in-a-pull-request.md | 1 + data/reusables/repositories/multiple-lines-comment.md | 1 + data/reusables/repositories/start-line-comment.md | 2 +- 4 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 data/reusables/repositories/multiple-lines-comment.md diff --git a/content/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request.md b/content/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request.md index 4346c81f2859..22f6c57e0370 100644 --- a/content/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request.md +++ b/content/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request.md @@ -47,6 +47,7 @@ To reply to an existing line {% ifversion pull-request-comment-on-file %}or file 1. In the list of pull requests, click the pull request where you'd like to leave line comments. {% data reusables.repositories.changed-files %} {% data reusables.repositories.start-line-comment %} +{% data reusables.repositories.multiple-lines-comment %} {% data reusables.repositories.type-line-comment %} {% data reusables.repositories.suggest-changes %} {% ifversion pull-request-comment-on-file %} diff --git a/content/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request.md b/content/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request.md index 4ff83a4fcd19..64701f782624 100644 --- a/content/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request.md +++ b/content/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request.md @@ -37,6 +37,7 @@ You can change the format of the diff view in this tab by clicking {% octicon "g 1. Optionally, if you have access to {% data variables.product.prodname_copilot_enterprise %}, you can ask {% data variables.product.prodname_copilot_short %} about the changes in a file in a pull request by clicking {% octicon "kebab-horizontal" aria-label="Show options" %} at the top right of the file, clicking **Ask {% data variables.product.prodname_copilot_short %} about this diff**, then typing a request such as "Explain these changes." For more information, see "[AUTOTITLE](/enterprise-cloud@latest/copilot/github-copilot-enterprise/copilot-chat-in-github/using-github-copilot-chat-in-githubcom#finding-out-about-the-changes-in-a-pull-request)." {%- endif %} {% data reusables.repositories.start-line-comment %} +{% data reusables.repositories.multiple-lines-comment %} {% data reusables.repositories.type-line-comment %} {% data reusables.repositories.suggest-changes %} {% ifversion pull-request-comment-on-file %} diff --git a/data/reusables/repositories/multiple-lines-comment.md b/data/reusables/repositories/multiple-lines-comment.md new file mode 100644 index 000000000000..49c11df5d22e --- /dev/null +++ b/data/reusables/repositories/multiple-lines-comment.md @@ -0,0 +1 @@ +1. Optionally, you can add a comment on multiple lines. You can click the line number of the first line you want to comment on and drag down to select a range of lines, then click {% octicon "plus" aria-label="The plus sign icon" %} on the last line you want to comment on. Alternatively, you can click {% octicon "plus" aria-label="The plus sign icon" %} next to the first line you want to comment on, then drag down to the last line you want to comment on. \ No newline at end of file diff --git a/data/reusables/repositories/start-line-comment.md b/data/reusables/repositories/start-line-comment.md index 2109650342e5..ea1cc6558a61 100644 --- a/data/reusables/repositories/start-line-comment.md +++ b/data/reusables/repositories/start-line-comment.md @@ -1,3 +1,3 @@ -1. Hover over the line of code where you'd like to add a comment, and click the blue comment icon. To add a comment on multiple lines, click on a line in the line number gutter area and drag to select the range of lines, then click the blue comment icon, or initially click on the blue comment icon and drag to select the range of lines. +1. Hover over the line of code where you'd like to add a comment, and click the blue comment icon. ![Screenshot of a diff in a pull request. Next to a line number, a blue plus icon is highlighted with an orange outline.](/assets/images/help/commits/hover-comment-icon.png) From a1968659de17371a9ce48afa05362749c9ce988f Mon Sep 17 00:00:00 2001 From: Denis Vakulenko <00vakulenko@gmail.com> Date: Sat, 18 May 2024 10:52:36 +0500 Subject: [PATCH 3/4] Add single newline character --- data/reusables/repositories/multiple-lines-comment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/reusables/repositories/multiple-lines-comment.md b/data/reusables/repositories/multiple-lines-comment.md index 49c11df5d22e..30459bfd68b3 100644 --- a/data/reusables/repositories/multiple-lines-comment.md +++ b/data/reusables/repositories/multiple-lines-comment.md @@ -1 +1 @@ -1. Optionally, you can add a comment on multiple lines. You can click the line number of the first line you want to comment on and drag down to select a range of lines, then click {% octicon "plus" aria-label="The plus sign icon" %} on the last line you want to comment on. Alternatively, you can click {% octicon "plus" aria-label="The plus sign icon" %} next to the first line you want to comment on, then drag down to the last line you want to comment on. \ No newline at end of file +1. Optionally, you can add a comment on multiple lines. You can click the line number of the first line you want to comment on and drag down to select a range of lines, then click {% octicon "plus" aria-label="The plus sign icon" %} on the last line you want to comment on. Alternatively, you can click {% octicon "plus" aria-label="The plus sign icon" %} next to the first line you want to comment on, then drag down to the last line you want to comment on. From e2f2bdcbdde43ee6297773ba11dd6b946379cf5d Mon Sep 17 00:00:00 2001 From: Ben Ahmady <32935794+subatoi@users.noreply.github.com> Date: Mon, 20 May 2024 15:17:37 +0100 Subject: [PATCH 4/4] Update data/reusables/repositories/multiple-lines-comment.md --- data/reusables/repositories/multiple-lines-comment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/reusables/repositories/multiple-lines-comment.md b/data/reusables/repositories/multiple-lines-comment.md index 30459bfd68b3..96c50cc0a99e 100644 --- a/data/reusables/repositories/multiple-lines-comment.md +++ b/data/reusables/repositories/multiple-lines-comment.md @@ -1 +1 @@ -1. Optionally, you can add a comment on multiple lines. You can click the line number of the first line you want to comment on and drag down to select a range of lines, then click {% octicon "plus" aria-label="The plus sign icon" %} on the last line you want to comment on. Alternatively, you can click {% octicon "plus" aria-label="The plus sign icon" %} next to the first line you want to comment on, then drag down to the last line you want to comment on. +1. Optionally, you can add a comment on multiple lines. You can click the line number of the first line you want to comment on and drag down to select a range of lines, then click the blue comment icon on the last line you want to comment on. Alternatively, you can click the blue comment icon next to the first line you want to comment on, then drag down to the last line you want to comment on.