-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default value not used ? #111
Comments
At the moment, no default values are used. I can definitely set these! For now, I will set them to assume that the user is running local-action run . src/main.ts .env |
Hmm....actually on second thought I think I might hold off on this. The issue is the tool doesn't currently know the type of action being run (JavaScript or TypeScript...or hopefully eventually container/composite). |
This was very unexpected - and it means we must explicitly pass in all the defaults again. |
Apologies, I think I misunderstood the original intent of the request. I was assuming this meant the defaults for the |
This should do the trick: #139 v2.5.0 should be available on npm shortly. Please open an issue if you see any problems! |
Awesome - thanks! With this now working, I'm not sure if having a .env file is always necessary. Might want to remove that requirement? |
I would say yes but there are a bunch of other configuration flags in there, not including inputs. |
Totally - but they are not required, and can be passed in via actual env vars. Currently I'm only using inputs in mine, so once this lands, I'll have the requirement of creating an empty .env file which feels a bit weird. |
Also! Getting an error now |
ok - confirmed that the issue is that the default value coming through is a boolean |
Can we open a separate issue to track this? FYI the GitHub YAML schema expects a Edit: I will follow up in the open PR and we can discuss there :) |
I think that default value seems not to be used for input, right ?
It should be possible to add this ?
It should be interresting to can test these default value behaviour from the cli.
The text was updated successfully, but these errors were encountered: