Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delay notification removal #1092

Merged
merged 5 commits into from
May 9, 2024
Merged

Conversation

setchy
Copy link
Member

@setchy setchy commented May 8, 2024

Add new Notification Settings which allows users to "delay" notifications from being removed from Gitify upon user interactions (marked as done, marked as read, open).

When enabled, notification rows will be set temporarily as opaque until they're removal upon next refresh (scheduled or user initiated).

Defaulted to disabled.

Demo
https://github.com/gitify-app/gitify/assets/386277/812a2f1c-0a15-406d-91c1-00210b432387

Closes #319

@setchy setchy added the enhancement New feature or enhancement to existing functionality label May 8, 2024
@setchy setchy added this to the Release 5.6.0 milestone May 8, 2024
src/utils/remove-notification.test.ts Outdated Show resolved Hide resolved
@afonsojramos
Copy link
Member

Nice one! Interesting feature, definitely one that feels weird at first but then feels useful!

@setchy
Copy link
Member Author

setchy commented May 9, 2024

Nice one! Interesting feature, definitely one that feels weird at first but then feels useful!

I know right! I think it's actually one that I might personally enable

@setchy setchy merged commit 9c2248c into main May 9, 2024
7 checks passed
@setchy setchy deleted the feature/delay-notification-remove branch May 9, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop re-ordering notifications when I mark one as read
2 participants