Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model_category should be inferred #54

Open
Gonmeso opened this issue Jun 3, 2024 · 3 comments
Open

model_category should be inferred #54

Gonmeso opened this issue Jun 3, 2024 · 3 comments

Comments

@Gonmeso
Copy link
Contributor

Gonmeso commented Jun 3, 2024

Currently we leave to the user to use the model_category variable to indicate if its ONNX or XGB. This should be inferred from the data of the version and the original model, not to users input.

Error prone:

(result, proof_id) = model.predict(
        input_feed={"input": input}, verifiable=True, model_category="XGB"
    )

Inferred:

# In the instantiation we can check the original model or if is json, we can get from it the model XGB or LGBM
model = GizaModel(id=model_id, version=version_id)
(result, proof_id) = model.predict(
        input_feed={"input": input}, verifiable=True
    )
@Jonatan-Chaverri
Copy link

I will like to take care of this one

@Bosun-Josh121
Copy link

Can get this done and ready within few hours, I understand that I'm to get the required value from the data version/original model as opposed to using human input value that is unreliable.

@Gonmeso
Copy link
Contributor Author

Gonmeso commented Jun 26, 2024

Hi @Jonatan-Chaverri @Josh-121

Sorry for the late response, currently we are putting this a bit on hold while we work on a refactor in the following months

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants