Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to update PARTIALLY_SUPPORTED versions #43

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Allow to update PARTIALLY_SUPPORTED versions #43

merged 5 commits into from
Feb 12, 2024

Conversation

Gonmeso
Copy link
Collaborator

@Gonmeso Gonmeso commented Feb 9, 2024

Now a version will be allowed to update the cairo code if it compiles successfully:

  • Check that the version is PARTIALLY_SUPPORTED if any other status the version is NOT allowed to update
  • Check that scarb its installed
  • Try to compile the model, if it compiles the cairo code and sierra file are uploaded and updated in Giza
  • Updated tests
  • Added ExceptionHandler to handle common CLI errors like HTTPError or ValidationError

@Gonmeso Gonmeso requested a review from franalgaba February 9, 2024 10:12
@Gonmeso Gonmeso merged commit b3c7c30 into main Feb 12, 2024
2 checks passed
@Gonmeso Gonmeso deleted the gonzalo/giz-349-giza-api-version-update-with-latest-cairo-code-for-partial branch February 12, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franalgaba franalgaba Awaiting requested review from franalgaba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Gonmeso