Skip to content

Commit 30156ae

Browse files
committed
V2.8.1.2
1 parent cdac1f2 commit 30156ae

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

Readme.md

+3
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,9 @@ Known Issues
246246

247247
History
248248
=============
249+
25th February 2015 Version 2.8.2.1
250+
1. Fixed 'Arrows still show when editing is on.' - #13.
251+
249252
21st December 2014 Version 2.8.2
250253
1. Revamped the arrows such that they are always visible.
251254
2. Arrow and close image size responsive to screen size.

module.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ M.format_grid.init = function(Y, the_editing_on, the_section_redirect, the_num_s
8484
// Show the sections when editing.
8585
Y.all(".grid_section").removeClass('hide_section');
8686
} else {
87-
8887
Y.delegate('click', this.icon_click, Y.config.doc, 'ul.gridicons a.gridicon_link', this);
8988

9089
var shadeboxtoggleone = Y.one("#gridshadebox_overlay");
@@ -99,10 +98,12 @@ M.format_grid.init = function(Y, the_editing_on, the_section_redirect, the_num_s
9998
var shadeboxarrowleft = Y.one("#gridshadebox_left");
10099
if (shadeboxarrowleft) {
101100
shadeboxarrowleft.on('click', this.arrow_left, this);
101+
document.getElementById("gridshadebox_left").style.display = "";
102102
}
103103
var shadeboxarrowright = Y.one("#gridshadebox_right");
104104
if (shadeboxarrowright) {
105105
shadeboxarrowright.on('click', this.arrow_right, this);
106+
document.getElementById("gridshadebox_right").style.display = "";
106107
}
107108
// Remove href link from icon anchors so they don't compete with JavaScript onlick calls.
108109
var icon_links = getElementsByClassName(document.getElementById("gridiconcontainer"), "a", "gridicon_link");

renderer.php

+5-3
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,12 @@ public function print_multiple_section_page($course, $sections, $mods, $modnames
119119
echo html_writer::start_tag('div', array('id' => 'gridiconcontainer', 'role' => 'navigation',
120120
'aria-label' => get_string('gridimagecontainer', 'format_grid')));
121121
echo html_writer::start_tag('ul', array('class' => 'gridicons'));
122-
// Print all of the imaege containers.
122+
// Print all of the image containers.
123123
$this->make_block_icon_topics($context->id, $modinfo, $course, $editing, $hascapvishidsect, $urlpicedit);
124124
echo html_writer::end_tag('ul');
125125
echo html_writer::end_tag('div');
126126
echo html_writer::start_tag('div', array('id' => 'gridshadebox'));
127-
echo html_writer::tag('div', '', array('id' => 'gridshadebox_overlay', 'style' => 'display:none;'));
127+
echo html_writer::tag('div', '', array('id' => 'gridshadebox_overlay', 'style' => 'display: none;'));
128128
echo html_writer::start_tag('div', array('id' => 'gridshadebox_content', 'class' => 'hide_content',
129129
'role' => 'region',
130130
'aria-label' => get_string('shadeboxcontent', 'format_grid')));
@@ -140,7 +140,7 @@ public function print_multiple_section_page($course, $sections, $mods, $modnames
140140
default:
141141
break;
142142
}
143-
echo html_writer::tag('img', '', array('id' => 'gridshadebox_close', 'style' => 'display:none;',
143+
echo html_writer::tag('img', '', array('id' => 'gridshadebox_close', 'style' => 'display: none;',
144144
'class' => $deviceextra,
145145
'src' => $this->output->pix_url('close', 'format_grid'),
146146
'role' => 'link',
@@ -150,13 +150,15 @@ public function print_multiple_section_page($course, $sections, $mods, $modnames
150150
if (($course->numsections > 1) || (($course->numsections == 1) && (!$this->topic0_at_top))) {
151151
echo html_writer::start_tag('div', array('id' => 'gridshadebox_left',
152152
'class' => 'gridshadebox_left_area',
153+
'style' => 'display: none;',
153154
'role' => 'link',
154155
'aria-label' => get_string('previoussection', 'format_grid')));
155156
echo html_writer::tag('img', '', array('class' => 'gridshadebox_arrow gridshadebox_left'.$deviceextra,
156157
'src' => $this->output->pix_url('fa-arrow-circle-left-w', 'format_grid')));
157158
echo html_writer::end_tag('div');
158159
echo html_writer::start_tag('div', array('id' => 'gridshadebox_right',
159160
'class' => 'gridshadebox_right_area',
161+
'style' => 'display: none;',
160162
'role' => 'link',
161163
'aria-label' => get_string('nextsection', 'format_grid')));
162164
echo html_writer::tag('img', '', array('class' => 'gridshadebox_arrow gridshadebox_right'.$deviceextra,

version.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
defined('MOODLE_INTERNAL') || die();
3030

3131
// Plugin version.
32-
$plugin->version = 2014122100;
32+
$plugin->version = 2015022500;
3333

3434
// Required Moodle version.
3535
$plugin->requires = 2014111000.00; // 2.8 (Build: 20141110).
@@ -41,4 +41,4 @@
4141
$plugin->maturity = MATURITY_STABLE;
4242

4343
// User-friendly version number.
44-
$plugin->release = '2.8.2';
44+
$plugin->release = '2.8.2.1';

0 commit comments

Comments
 (0)