Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIs for changing package owners and rename revert_package to remove_owner #29

Merged
merged 2 commits into from
May 30, 2024

Conversation

Pi-Cla
Copy link

@Pi-Cla Pi-Cla commented May 22, 2024

It turns out that revert_package_request was actually for removing owners. I have tried to mitigate these mistakes in the future by making documentation over at #28 which has a somewhat reliable process for figuring out how the API works.

Part of gleam-lang/gleam#3155

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you update the changelog please?

Pi-Cla added 2 commits May 29, 2024 12:14
…ove_owner

It turns out that revert_package_request was actually for removing owners.
I have tried to mitigate these mistakes in the future by making documentation over at gleam-lang#28 which has a somewhat reliable process for figuring out how the API works.

Part of gleam-lang/gleam#3155
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lpil lpil merged commit cf75ac9 into gleam-lang:main May 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants