Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prov should note change to context #96

Open
fils opened this issue Jul 26, 2022 · 4 comments
Open

Prov should note change to context #96

fils opened this issue Jul 26, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@fils
Copy link
Member

fils commented Jul 26, 2022

If we have to align the context to a value, we should note that as part of the PROV record made by gleaner.

@fils fils self-assigned this Jul 26, 2022
@fils fils added the enhancement New feature or request label Jul 26, 2022
@fils
Copy link
Member Author

fils commented Aug 4, 2022

Looking at some issue with the context update..

Having a road block with sjon using two @ prefixed keywords in JSON-LD

see: tidwall/sjson#61

@fils
Copy link
Member Author

fils commented Aug 4, 2022

@valentinedwv @nein09

I have re-written the context changing code in a test program at https://github.com/gleanerio/gleaner/blob/df--dev/tools/contextChange/main.go

Was having some issues when used with different prefix values and string vs map issues. Hoping this might be a bit more robust. Feel free to look at it here and run it if you like. If I don't find any issues I will move it fulling into the internal code in dev-df and then do a pull request to dev.

Note: this doesn't address the PROV aspect, just addresses an issue with the context changing that needed to be resolved first.

@fils
Copy link
Member Author

fils commented Aug 4, 2022

@valentinedwv
Copy link
Member

Do we care if WE change the context to load the data? If the data is contextually the same and makes the system work that is a good thing
I think we are figuring out that standardizing the structure is beneficial to performance.

Noting 'enhancements' in prov should be a features. Providing feedback on these is good, but we should not expect the repos to fix them in a timely manner ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants