You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[...] addresses starting with bit combinations
1011, 1101 and 1111 have been reserved for future use.
Unfortunately, there are DDB entries of type 'I' with an address from the reserved range.
Test script:
#!/usr/bin/env python3
from ogn.utils import get_ddb
ddb = {}
for d in get_ddb():
id = int(d.address, 16)
ddb.update({id: d})
i = 0
for d in ddb:
# ICAO-Address in 'reserved for further use'-range
if ddb[d].address_type == 'I' and bin(d)[2:6] in ['1011','1101','1111']:
print('{}{}'.format(bin(d), ddb[d]))
i += 1
print("%i entries" % i)
# current Result: '102 entries'
The text was updated successfully, but these errors were encountered:
Some time ago, gewesp mentioned the same issue on the ML: ID types in DDB (login required...) @gewesp: Do you know the range of valid 24bit-addresses for flarm devices (factory settings)?
RfC: Add validation for newly entered addresses.
For I-device_type addresses, either disallow addresses starting with B16 (1011), D16 (1101) and F16 (1111) or explicitely whitelist the respective ranges defined by ICAO Annex 10 Volume III - Chapter 9. Aircraft Addressing System.
ID type
disallowed
I
all addresses starting with B16, D16 and F16
F
tbd, guessing addresses starting with DD16 and others
O
nothing (but recommend addresses starting with B16, D16 and F16)
Or should we drop the device_type since it's data is wrong and thus useless?
(increasing the probability of collisions duplicates)
Edit:
Replaced "collisions" by "duplicates", since it has a double meaning in this context. 😃
We should add input validation for ICAO-IDs.
Why?
According to http://www.kloth.net/radio/icao24alloc.php,
Unfortunately, there are DDB entries of type 'I' with an address from the reserved range.
Test script:
The text was updated successfully, but these errors were encountered: