Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rtlsdr-ogn.conf conffile #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kerel-fs
Copy link
Contributor

@Romeo-Golf
Copy link

Would it be possible to avoid adding a second, unique, file which is named rtlsdr-ogn.conf to avoid confusion with one used to configure the shellbox service at https://github.com/glidernet/ogn-rf/blob/master/rtlsdr-ogn.conf, perhaps by calling this file example.conf or similar ?

@kerel-fs
Copy link
Contributor Author

kerel-fs commented Feb 16, 2017

The canonic paths for the configuration file of a package rtlsdr-ogn are /etc/rtlsdr-ogn.conf or /etc/rtlsdr-ogn/rtlsdr-ogn.conf.
Since the shellbox service should die imho (the upcoming debian package will use systemd instead),
there won't be a risk of confusion in the future (at least for new users^^).
Admittedly I see a risk of confusion for old users.

@Romeo-Golf
Copy link

fair points, but to look at it another way.... is there any reason not to call the example config file something like example.conf? :)

@kerel-fs
Copy link
Contributor Author

I fully agree with that last sentence.
You just triggered me to express my own concerns about the path /etc/rtlsdr-ogn.conf. :)

kerel-fs added a commit to kerel-fs/ogn-rf that referenced this pull request Feb 20, 2017
kerel-fs added a commit to kerel-fs/ogn-rf that referenced this pull request May 19, 2017
Add PipeName to rtlsdr-ogn.conf configuration file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants