Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catch to stop unsaved annotations not saving #493

Open
joshuajames-smith opened this issue Dec 9, 2021 · 3 comments
Open

Add catch to stop unsaved annotations not saving #493

joshuajames-smith opened this issue Dec 9, 2021 · 3 comments
Labels
feature [Improvement] New feature request.

Comments

@joshuajames-smith
Copy link
Contributor

Is your feature request related to a problem? Please describe

From a UX perspective, users are used to sometimes just closing the page and expecting work to save.
At the moment, we have no catch (hard or internal navigation) that prevents the navigation until user has indicted whether they want their annotation saved. Similarly, marking annotation as complete feels like it should save!

Describe the solution you'd like

A catch which knows there is unsaved annotations and opens a dialogue to ensure the user gets a chance to save their annotations before losing them.
(hard nav = refresh, back | soft nav = internal nav = return to curate)

The mark annotations as complete should also be a save function.

Describe alternatives you've considered

N/A

Additional context

N/A

@ChasNelson1990
Copy link
Member

I thought we dealt with this? Or parts of it at least?

@joshuajames-smith
Copy link
Contributor Author

I thought we dealt with this? Or parts of it at least?

I think we did talk about it. This issue is still present with me playing about on staging just now!

@ChasNelson1990 ChasNelson1990 removed their assignment Jan 6, 2022
@joshuajames-smith joshuajames-smith added feature [Improvement] New feature request. and removed enhancement [Improvement] Enhancement request. labels Jan 12, 2022
@joshuajames-smith
Copy link
Contributor Author


  • Hard Navigation, i.e. Refresh or Back > Unsaved Annotation Catch > Present Dialogue [below]
  • Soft Navigation, i.e. Open "Active-Project" in CURATE > Unsaved Annotation Catch > Present Dialogue [below]

ANNOTATE

Dialogue should appear by catching unsaved annotations during user soft or hard navigation. The dialogue feedbacks to the user that they have unsaved annotations, preventing loss of work if unintentional.

If user clicks Save Annotations [purple button], this should save before allowing user soft or hard navigation to proceed.
If user clicks the Don't Save [empty button], this should ignore Savin and allow user soft or hard navigation to proceed.
If user clicks the Cancel [cross icon], this should then cancel user soft or hard navigation and remain on annotate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature [Improvement] New feature request.
Projects
None yet
Development

No branches or pull requests

5 participants