Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new content and fixing templates #18

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

diego7marques
Copy link
Collaborator

@diego7marques diego7marques commented Oct 25, 2024

This was referenced Oct 25, 2024
@tigpt
Copy link
Member

tigpt commented Oct 25, 2024

Really great work, but for the future, it would be better to have 1 PR per issue to not need have to accept or deny all together. There may be an problem in one of the things holding the whole PR down.

Copy link
Member

@tigpt tigpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good to me.

@tigpt tigpt merged commit 9b14df1 into global-aws-community:main Oct 25, 2024
@diego7marques diego7marques deleted the feature/add-new-stuff branch October 30, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants