Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e cache #568

Merged
merged 23 commits into from
Feb 27, 2025
Merged

fix: e2e cache #568

merged 23 commits into from
Feb 27, 2025

Conversation

farrellh1
Copy link
Contributor

Description

fixing e2e cache due to vue dev tools

Fixes # (issue)

Contribution

For your PR please add a comment to each file edited to explain the changes you made.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines

  • Docs have been added / updated (for bug fixes / features)

Checklist

  • /app
npm run build
npm run test:unit
npm run type-check
npm run lint
npm run format
  • /backend
npm run build
npm run test
npm run lint
npm run format
  • /contract
npm run test
npm run lint
npm run format

@farrellh1 farrellh1 self-assigned this Feb 3, 2025
@farrellh1 farrellh1 added bug Something isn't working CI CD labels Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (63e4c4c) to head (62e6712).
Report is 25 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #568      +/-   ##
===========================================
- Coverage    79.40%   76.85%   -2.55%     
===========================================
  Files          170      164       -6     
  Lines         6424     5847     -577     
  Branches      1955     1743     -212     
===========================================
- Hits          5101     4494     -607     
- Misses        1050     1071      +21     
- Partials       273      282       +9     
Flag Coverage Δ
app-unit-tests 78.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aliassan
Copy link
Contributor

aliassan commented Feb 4, 2025

So why is it failing on this PR?

@farrellh1
Copy link
Contributor Author

the cache failing because of the vue-dev-tools, but now the teams.spec failing because of the team creation flow changed @aliassan

Copy link
Contributor

@hermannleboss hermannleboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hermannleboss hermannleboss merged commit f12be93 into develop Feb 27, 2025
6 of 7 checks passed
@hermannleboss hermannleboss deleted the fix/e2e-cache branch February 27, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants