-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: e2e cache #568
fix: e2e cache #568
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #568 +/- ##
===========================================
- Coverage 79.40% 76.85% -2.55%
===========================================
Files 170 164 -6
Lines 6424 5847 -577
Branches 1955 1743 -212
===========================================
- Hits 5101 4494 -607
- Misses 1050 1071 +21
- Partials 273 282 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
So why is it failing on this PR? |
the cache failing because of the vue-dev-tools, but now the teams.spec failing because of the team creation flow changed @aliassan |
…verage to Codecov
…rict type checking
…or team data setup
…mprove selector usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
fixing e2e cache due to vue dev tools
Fixes # (issue)
Contribution
For your PR please add a comment to each file edited to explain the changes you made.
Type of change
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)
Please check if the PR fulfills these requirements
The commit message follows our guidelines
Docs have been added / updated (for bug fixes / features)
Checklist
npm run build npm run test npm run lint npm run format
npm run test npm run lint npm run format