Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: contract deployment in Officer contract #583

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

farrellh1
Copy link
Contributor

Description

refactor: contract deployment in Officer contract

Fixes # (issue)

Contribution

For your PR please add a comment to each file edited to explain the changes you made.

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines

  • Tests for the changes have been added (for bug fixes/features)

Checklist

  • /app
npm run build
npm run test:unit
npm run type-check
npm run lint
npm run format
  • /backend
npm run build
npm run test
npm run lint
npm run format
  • /contract
npm run test
npm run lint
npm run format

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.15%. Comparing base (45f0765) to head (89fc69a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #583      +/-   ##
===========================================
- Coverage    79.17%   79.15%   -0.02%     
===========================================
  Files          169      169              
  Lines         6406     6401       -5     
  Branches      1957     1957              
===========================================
- Hits          5072     5067       -5     
  Misses        1058     1058              
  Partials       276      276              
Flag Coverage Δ
app-unit-tests 78.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@farrellh1 farrellh1 linked an issue Feb 25, 2025 that may be closed by this pull request
@farrellh1
Copy link
Contributor Author

will fix the tests if we are going with this approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Officer contract deployment flow
1 participant