-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/split expense account approved addresses #586
Merged
aliassan
merged 15 commits into
develop
from
refactor/split-expense-account-approved-addresses
Feb 26, 2025
Merged
Refactor/split expense account approved addresses #586
aliassan
merged 15 commits into
develop
from
refactor/split-expense-account-approved-addresses
Feb 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #586 +/- ##
===========================================
+ Coverage 79.17% 79.40% +0.22%
===========================================
Files 169 170 +1
Lines 6406 6424 +18
Branches 1957 1955 -2
===========================================
+ Hits 5072 5101 +29
+ Misses 1058 1050 -8
+ Partials 276 273 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split expense account into sections. Add the logic to my approved addresses table
Fixes # (issue)
Contribution
For your PR please add a comment to each file edited to explain the changes you made.
Type of change
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)
Please check if the PR fulfills these requirements
The commit message follows our guidelines
Tests for the changes have been added (for bug fixes/features)
Docs have been added / updated (for bug fixes / features)
Checklist
npm run build npm run test npm run lint npm run format
npm run test npm run lint npm run format