Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/split expense account approved addresses #586

Merged
merged 15 commits into from
Feb 26, 2025

Conversation

aliassan
Copy link
Contributor

Description

Split expense account into sections. Add the logic to my approved addresses table

Fixes # (issue)

Contribution

For your PR please add a comment to each file edited to explain the changes you made.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines

  • Tests for the changes have been added (for bug fixes/features)

  • Docs have been added / updated (for bug fixes / features)

Checklist

  • /app
npm run build
npm run test:unit
npm run type-check
npm run lint
npm run format
  • /backend
npm run build
npm run test
npm run lint
npm run format
  • /contract
npm run test
npm run lint
npm run format

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 83.13253% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.40%. Comparing base (45f0765) to head (63e4c4c).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
...mposables/expense-account/useExpenseAccountData.ts 53.33% 12 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #586      +/-   ##
===========================================
+ Coverage    79.17%   79.40%   +0.22%     
===========================================
  Files          169      170       +1     
  Lines         6406     6424      +18     
  Branches      1957     1955       -2     
===========================================
+ Hits          5072     5101      +29     
+ Misses        1058     1050       -8     
+ Partials       276      273       -3     
Flag Coverage Δ
app-unit-tests 78.87% <83.13%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aliassan aliassan marked this pull request as ready for review February 25, 2025 19:58
@aliassan aliassan merged commit 7b843e6 into develop Feb 26, 2025
6 of 7 checks passed
@aliassan aliassan deleted the refactor/split-expense-account-approved-addresses branch February 26, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant