Free created types in destructors

glotzerlab · Nov 20, 2024 · 379afa9 · 379afa9
1 parent b116410
commit 379afa9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/hoomd/MPIConfiguration.cc b/hoomd/MPIConfiguration.cc
@@ -94,6 +94,14 @@ MPIConfiguration::MPIConfiguration(
 #endif
     }
 
+MPIConfiguration::~MPIConfiguration()
+    {
+    MPI_Type_free(&m_mpi_scalar2);
+    MPI_Type_free(&m_mpi_scalar3);
+    MPI_Type_free(&m_mpi_vec3_scalar);
+    MPI_Type_free(&m_mpi_scalar4);
+    }
+
 void MPIConfiguration::splitPartitions(unsigned int nrank)
     {
 #ifdef ENABLE_MPI

diff --git a/hoomd/MPIConfiguration.h b/hoomd/MPIConfiguration.h
@@ -45,7 +45,7 @@ class PYBIND11_EXPORT MPIConfiguration
     );
 
     //! Destructor
-    virtual ~MPIConfiguration() { };
+    virtual ~MPIConfiguration();
 
 #ifdef ENABLE_MPI
     MPI_Comm operator()() const

diff --git a/hoomd/mpcd/ParticleData.cc b/hoomd/mpcd/ParticleData.cc
@@ -91,6 +91,9 @@ mpcd::ParticleData::ParticleData(const mpcd::ParticleDataSnapshot& snapshot,
 mpcd::ParticleData::~ParticleData()
     {
     m_exec_conf->msg->notice(5) << "Destroying MPCD ParticleData" << endl;
+#ifdef ENABLE_MPI
+    MPI_Type_free(&m_mpi_pdata_element);
+#endif // ENABLE_MPI
     }
 
 /*!