Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid removing and adding graph node when updating properties #1

Open
astrofrog opened this issue Jun 26, 2019 · 0 comments
Open

Avoid removing and adding graph node when updating properties #1

astrofrog opened this issue Jun 26, 2019 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@astrofrog
Copy link
Member

At the moment, whenever any aspect of a layer is changed, we remove the graph node from OpenSpace and add a new one (this is done in layer_artist.py). We should make sure that we only add the graph node once and then make updates by setting only the properties that need to be set. This can include:

  • Changing the data to be shown (e.g. if a subset changes, or the attributes for the RA/Dec change)
  • Color
  • Visibility
  • Transparency
  • Point size/brightness
@astrofrog astrofrog added enhancement New feature or request help wanted Extra attention is needed labels Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant