Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_python_export failures with affine coordinates #29

Open
dhomeier opened this issue Feb 12, 2025 · 2 comments
Open

test_python_export failures with affine coordinates #29

dhomeier opened this issue Feb 12, 2025 · 2 comments

Comments

@dhomeier
Copy link
Contributor

dhomeier commented Feb 12, 2025

Some of these tests have always failed with self.viewer_load('affine') ever since those coords were first added in

No idea if those AffineCoordinates make any sense at all, but they work – apart from the _slice and simple_att tests, that suffer from some fuzziness in the (lower axis) labels. Looks like the exported version does not get the 3D look quite right – can probably live with that?
glue_plot
expected

Originally posted by @dhomeier in glue-viz/glue#2335 (comment)

As of Astropy 7.0 those failures have shown up in 6 more tests, all in the same way mismatching just on the abscissa labels, and now xfailed as well in f349d72. Arguably the plots from the exported script (top image) are actually looking more correct, with matching font sizes, though I originally suspected that the larger fonts were somehow intended to create more of a "3D" look.

@astrofrog
Copy link
Member

I recently moved over some of the Python export tests to glue-core and fixed them in the process. We should actually remove them from here.

@dhomeier
Copy link
Contributor Author

dhomeier commented Feb 12, 2025

For all viewers? They are all covered by glue-viz/glue#2524, but those originally marked xfail still are off.
Locally I also have test_subset_transposed['affine'] failing with Astropy 7 on some missing minor ticks, but don't see that in CI.
So should I purge all 5 tests in #26?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants