Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the maximum Anki version constraint #24

Open
2 tasks done
oakkitten opened this issue Mar 26, 2022 · 1 comment
Open
2 tasks done

Remove the maximum Anki version constraint #24

oakkitten opened this issue Mar 26, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@oakkitten
Copy link

Checklist

  • I've verified that I use the latest version of pytest-anki
  • I've checked if anyone else suggested this feature before by looking through the issue reports.

Problem case

This makes it impossible to use the plugin with the newer Anki versions

anki = ">=2.1.28,<=2.1.47"
aqt = ">=2.1.28,<=2.1.47"

Solution

Remove the upper constraint. Hopefully the tested plugin defines their own Anki versions...

@oakkitten oakkitten added the enhancement New feature or request label Mar 26, 2022
@glutanimate
Copy link
Owner

Hey, thanks for the report! Since pytest-anki is tightly coupled to specific Anki version ranges (i.e. every now and then needs to be manually adjusted to retain support with newer Anki versions), my idea here was to use the upper bound to guarantee Anki version support. However, it's definitely an awkward solution and creates many problems of its own. (In an ideal world you'd have anki and aqt follow SemVer, so that API support would be somewhat codified in major/minor versions, but yeah.)

Let me give this another look and see if I can remove the constraint while still specifying a preferred / tested version of Anki to install.

But as a starter, will raise the minimum constraint to 2.1.49 for now, perhaps 2.1.50 if I have the time to test against it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants