Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Play" menu #6

Open
divergentdave opened this issue Dec 24, 2014 · 2 comments
Open

"Play" menu #6

divergentdave opened this issue Dec 24, 2014 · 2 comments

Comments

@divergentdave
Copy link
Contributor

Is the DVD selection menu still a work in progress? I get an error when I click on the "Play" button. It looks like the templating code should be $('.video-container').html(_.template(list)({dvds: data})); instead of $('.video-container').html(_.template(list, {dvds: data}));. I don't see where the cover.jpg files come from, are those supposed to be user-supplied? Thanks!

@gmarty
Copy link
Owner

gmarty commented Jan 2, 2015

Hi!
The template line looks good to me. I'll update the code to use precompiled template instead.
And yes, the cover.jpg must be supplied by the user.

@gmarty
Copy link
Owner

gmarty commented Jan 2, 2015

The change is here: d6418cc

Let me know if you still have the issue. Also this change shouldn't conflict with your current PR :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants