Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate network before creating transactions #15

Open
bagelface opened this issue Feb 2, 2024 · 0 comments
Open

Validate network before creating transactions #15

bagelface opened this issue Feb 2, 2024 · 0 comments
Labels
current scope Part of an active project scope

Comments

@bagelface
Copy link
Contributor

There are currently many buttons across the site that do not validate the user is on the current network before creating and submitting a transaction for approval. A few instances of this that I've noticed, but this is my no means exhaustive:

  • Voting on a prop
  • Delegating votes
  • Canceling votes on a prop

Most of these transactions do not involve sending ETH, which is the worse case scenario for an issue like this (a user that's connected to the wrong network approves a transaction that sends value to an address on a network where there is nothing deploy, which is very like to result in unrecoverable funds). However, it could result in users accidentally sending multiple transactions on the incorrect network and wasting gas funds.

I'd suggest one of two solutions for this: (1) Create a base component for buttons that create transactions and do validation there or (2) validating on page load and creating a blocking modal that prompts the user to switch to the correct network.

@bagelface bagelface added the current scope Part of an active project scope label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current scope Part of an active project scope
Projects
None yet
Development

No branches or pull requests

1 participant