Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proposal creator to work with Base contracts #23

Open
bagelface opened this issue Apr 13, 2024 · 11 comments
Open

Update proposal creator to work with Base contracts #23

bagelface opened this issue Apr 13, 2024 · 11 comments
Labels
blocked Blocked by another issue current scope Part of an active project scope

Comments

@bagelface
Copy link
Contributor

bagelface commented Apr 13, 2024

Description 🗒️

Update webapp proposal creator to work with Base contracts.


Details 🏗️

  • Update proposal creator: Update the webapp proposal creator to work with the Base contracts. All functionality available on the mainnet proposal creator should be available on the Base proposal creator.
  • Hide the delegation button: Delegations on Base will require a separate ticket. If that ticket has not been completed, take the opportunity to hide the delegation button so that users are not confused by it. Do not remove it.
  • Buttons require Base connection: Buttons that send a transaction are updated to not be "active" unless the user is connected to Base network. Otherwise these changes could accidentally send invalid transactions on mainnet and lose gas money.

Acceptance Criteria ☑️

  1. All of the changes described in the "Details" section above are implemented and tested.
  2. Code is clear, clean, and properly documented.
  3. UI changes are sensible and non-regressive.
@bagelface bagelface added enhancement New feature or request bounty Rewarded upon completion labels Apr 13, 2024
@Vayras
Copy link

Vayras commented Apr 14, 2024

@bagelface I would like to work on this issue, are there any general guidelines to start working on this? let me know Thanks

@bagelface
Copy link
Contributor Author

@bagelface I would like to work on this issue, are there any general guidelines to start working on this? let me know Thanks

Hey thanks for the interest. We give users in within the Gnars community first dibs on these issues. We'll leave it open to them for a week and then if no one is interested, it's all yours. If you'd like to join us in the Discord and get priority access read through this https://github.com/gnars-dao. We meet every Tuesday at 8pm EST

@reubenstein
Copy link

@bagelface Hey I'd be down to work on this. Vlad referred me. I'm millz.eth on discord

@reubenstein
Copy link

I got the frontend pulled down and running just fine; seems pretty straightforward, but logically it looks like #18 and #20 should come first. I'd be down to work on #20 but I'll wait to hear back before I start anything. In the meantime I applied to the Tech POD on Discord.

@bagelface
Copy link
Contributor Author

I got the frontend pulled down and running just fine; seems pretty straightforward, but logically it looks like #18 and #20 should come first. I'd be down to work on #20 but I'll wait to hear back before I start anything. In the meantime I applied to the Tech POD on Discord.

Yea you can definitely take this one. #18 definitely should be finished first, but I think this one and #20 can be worked on in parallel. Unless, there's something I've overlooked that couples them together somehow? @asmattic had mentioned wanting to grab #20 when he finishes up #18 on the last Tech Pod call, so if you're cool with grabbing this one that'd work out perfectly.

@reubenstein
Copy link

I got the frontend pulled down and running just fine; seems pretty straightforward, but logically it looks like #18 and #20 should come first. I'd be down to work on #20 but I'll wait to hear back before I start anything. In the meantime I applied to the Tech POD on Discord.

Yea you can definitely take this one. #18 definitely should be finished first, but I think this one and #20 can be worked on in parallel. Unless, there's something I've overlooked that couples them together somehow? @asmattic had mentioned wanting to grab #20 when he finishes up #18 on the last Tech Pod call, so if you're cool with grabbing this one that'd work out perfectly.

Great, I'll take this one then. I agree it can mostly be worked on in parallel with #20, the only cross-over I see is the "Buttons require Base connection" part..if there's any common logic between the auction component and the proposal component for the connection I would want to re-use that if possible to keep the code a little bit more DRY.

@bagelface bagelface assigned bagelface and reubenstein and unassigned bagelface Apr 30, 2024
@princyym
Copy link

princyym commented May 1, 2024

Hello @bagelface, as it has one assigned will my contribution be counts

@asmattic
Copy link
Contributor

asmattic commented May 1, 2024

I got the frontend pulled down and running just fine; seems pretty straightforward, but logically it looks like #18 and #20 should come first. I'd be down to work on #20 but I'll wait to hear back before I start anything. In the meantime I applied to the Tech POD on Discord.

Yea you can definitely take this one. #18 definitely should be finished first, but I think this one and #20 can be worked on in parallel. Unless, there's something I've overlooked that couples them together somehow? @asmattic had mentioned wanting to grab #20 when he finishes up #18 on the last Tech Pod call, so if you're cool with grabbing this one that'd work out perfectly.

Great, I'll take this one then. I agree it can mostly be worked on in parallel with #20, the only cross-over I see is the "Buttons require Base connection" part..if there's any common logic between the auction component and the proposal component for the connection I would want to re-use that if possible to keep the code a little bit more DRY.

That sounds good to me. Now that #18 is wrapped up I'm good to start work on #20 if there are no objections and @reubenstein and I can communicate and keep up to date on any potentially shared logic in parallel.

@reubenstein
Copy link

I got the frontend pulled down and running just fine; seems pretty straightforward, but logically it looks like #18 and #20 should come first. I'd be down to work on #20 but I'll wait to hear back before I start anything. In the meantime I applied to the Tech POD on Discord.

Yea you can definitely take this one. #18 definitely should be finished first, but I think this one and #20 can be worked on in parallel. Unless, there's something I've overlooked that couples them together somehow? @asmattic had mentioned wanting to grab #20 when he finishes up #18 on the last Tech Pod call, so if you're cool with grabbing this one that'd work out perfectly.

Great, I'll take this one then. I agree it can mostly be worked on in parallel with #20, the only cross-over I see is the "Buttons require Base connection" part..if there's any common logic between the auction component and the proposal component for the connection I would want to re-use that if possible to keep the code a little bit more DRY.

That sounds good to me. Now that #18 is wrapped up I'm good to start work on #20 if there are no objections and @reubenstein and I can communicate and keep up to date on any potentially shared logic in parallel.

Sounds good, I'll get started on this one today.

@BlockchainViper
Copy link

Hi is this task open I would like to work on it?

@bagelface
Copy link
Contributor Author

Hi is this task open I would like to work on it?

Potentially. Please join us on our Tech Pod call tomorrow at 20:00 UTC-4 (EST) and we can discuss.

@bagelface bagelface added current scope Part of an active project scope and removed bounty Rewarded upon completion enhancement New feature or request labels Aug 2, 2024
@bagelface bagelface changed the title Frontend - Update webapp proposal creator to work with Base contracts Update webapp proposal creator to work with Base contracts Aug 2, 2024
@bagelface bagelface changed the title Update webapp proposal creator to work with Base contracts Update proposal creator to work with Base contracts Aug 2, 2024
@bagelface bagelface added the blocked Blocked by another issue label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by another issue current scope Part of an active project scope
Projects
None yet
Development

No branches or pull requests

6 participants