Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solutions might not be accepted due to too big order amounts #708

Open
josojo opened this issue Apr 30, 2020 · 0 comments
Open

Solutions might not be accepted due to too big order amounts #708

josojo opened this issue Apr 30, 2020 · 0 comments
Labels
Version2 Proposals for the version 2 contract

Comments

@josojo
Copy link
Contributor

josojo commented Apr 30, 2020

If there are orders in the system, which have huge order amounts in the range of max uint256, these orders might not be accepted in a solution provision.

During the solution calculation, it might happen that the following line throws, due to a calculation overflow:
https://github.com/gnosis/dex-contracts/blob/master/contracts/BatchExchange.sol#L743

One example instance is here.

Find a better calculation for the utility in the next version of the smart contract.

@josojo josojo added the Version2 Proposals for the version 2 contract label Apr 30, 2020
@josojo josojo changed the title Prevent overflow Solutions might not be accepted due to too big order amounts May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version2 Proposals for the version 2 contract
Projects
None yet
Development

No branches or pull requests

1 participant