Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sharing is Caring] Move truffle-assertions typings upstream. #743

Open
nlordell opened this issue May 7, 2020 · 2 comments
Open

[Sharing is Caring] Move truffle-assertions typings upstream. #743

nlordell opened this issue May 7, 2020 · 2 comments
Labels

Comments

@nlordell
Copy link
Contributor

nlordell commented May 7, 2020

They can either be moved to be part of the truffle-assertions project directly or part of the @types organization.

They are relatively simple typings here:
https://github.com/gnosis/dex-contracts/blob/master/types/truffle-assertions/index.d.ts

@bh2smith
Copy link
Contributor

I'm not sure I understand the goal here. Are we to move the content of the file linked in the description to a different repo? Like truffle-assertions?

@nlordell nlordell assigned nlordell and unassigned nlordell May 22, 2020
@nlordell
Copy link
Contributor Author

Turns out its a little more complicated - there are some type dependencies that need to be setup correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants