New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wrapped `BoxFuture` type with `must_use` #1375

Open

nlordell opened this issue Aug 28, 2020 · 0 comments

Labels

cleanup

Contributor

nlordell commented Aug 28, 2020 •

edited

Loading

Nice catch!

rust-lang/futures-rs#1691 has a proposal on how this could be worked around (by wrapping the actual BoxFuture in a struct and marking it must_use).

I'd be in favour of using such a type in our codebase wherever we return BoxFuture as these bugs can be really nasty to find (not caught by unit tests) and I really like the rust compiler warnings in these cases.

nlordell added the cleanup label

e00E mentioned this issue

Convert BoxFuture to async_trait #1380

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment