Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oba] Pulling actual balances from the ethereum chain #1436

Open
josojo opened this issue Sep 22, 2020 · 0 comments
Open

[oba] Pulling actual balances from the ethereum chain #1436

josojo opened this issue Sep 22, 2020 · 0 comments
Labels
oba One Batch Auctions

Comments

@josojo
Copy link
Contributor

josojo commented Sep 22, 2020

In order to solve the problem properly, we have to investigate the balance and allowance of each owner of an order before we start solving the batch. Hence, we need some service to get us the latest information. There are different approaches:

  • Reading all Transfer and Allowance events and store them on our instances: While it might be a good technical solution, its effort is quite high.
  • Asking our nodes directly via smart contract reads: This might not be performant enough for many orders. Though, we don't expect too many orders to be matched at the beginning
  • Asking an external API: https://etherscan.io/apis#tokens: This one will not be available for our testnets :(
@nlordell nlordell added the oba One Batch Auctions label Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oba One Batch Auctions
Projects
None yet
Development

No branches or pull requests

2 participants